Skip to content

Corrected touch target boundaries for various chart types#791

Open
venkatbhoogarbh wants to merge 2 commits into
AppDevNext:masterfrom
venkatbhoogarbh:fix/stacked-bar-highlighter
Open

Corrected touch target boundaries for various chart types#791
venkatbhoogarbh wants to merge 2 commits into
AppDevNext:masterfrom
venkatbhoogarbh:fix/stacked-bar-highlighter

Conversation

@venkatbhoogarbh

Copy link
Copy Markdown

Fix: Corrected touch target boundaries and stack selection logic for Bar charts, Pie charts, Stack charts, and many more

…Bar charts, Pie charts, Stack charts, and many more
@hannesa2

Copy link
Copy Markdown
Collaborator

Hm, I'm not sure if we bump minSdk to 24 only because of this. Please give me an argument to do so.

/home/runner/work/AndroidChart/AndroidChart/chartLib/src/main/kotlin/info/appdev/charting/renderer/BarChartRenderer.kt:60: Error: Call requires API level 24, or core library desugaring (current min is 23): java.lang.Iterable#forEach [NewApi]
        barData?.dataSets?.forEach {
                           ~~~~~~~

@hannesa2

Copy link
Copy Markdown
Collaborator

according to https://apilevels.com/
image

@venkatbhoogarbh

Copy link
Copy Markdown
Author

I changed it appropriately to use a standard for-in loop, preserving full API 23 compatibility. Thank you for pointing that out!

@hannesa2

Copy link
Copy Markdown
Collaborator

Thanks a lot for your afford. As forks can't makes screenshot compare test, I made a copy of this PR #794 to enable this.
Additional I'll invite you, then you can push to upstream and can pull requests with screenshot compare machanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants