[P2-018] Run batch files in the build slot by full path - #4
Merged
Merged
Conversation
The first real build through `build-slot run` failed with "'gradlew.bat' is not recognized": this workstation sets NoDefaultCurrentDirectoryInExePath, so cmd.exe does not search the current directory, and the documented `-- cmd /c gradlew.bat` example cannot work. build-slot run now runs a .bat/.cmd command from the current directory through cmd /c by its full path, and the procedure documents `-- gradlew.bat build`. The offline build-slot test covers a batch file named without a path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. The first real build through
build-slot runfailed with "'gradlew.bat' is not recognized". This workstation setsNoDefaultCurrentDirectoryInExePath=1, socmd.exedoes not search the current directory, and the documented-- cmd /c gradlew.bat buildexample cannot work.build-slot runnow runs a.bator.cmdcommand from the current directory throughcmd /cby its full path.arcforges-implementation.mddocuments-- gradlew.bat build.Validation:
python -m unittest discover -s tools/tests, run through the build slot, passed all 17 tests.🤖 Generated with Claude Code