feat: add standalone Tasks and Jobs skills - #3
Open
bruno-archastro wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
ArchDev v0.33.2 exposes Tasks and Jobs as separate CLI domains, but agents cannot install domain-specific operating guidance from the public distribution repository. Today the flow stops at
npx skills add: there is no Tasks or Jobs package to copy, no cold-machine bootstrap, and no documented ownership boundary between authentication and the local runner.The public installers also still expect the retired
archdev-dashboardsidecar. Current release archives contain onlyarchdev, so a clean installation downloads and verifies the archive, extracts it, then aborts withArchive is missing archdev-dashboardinstead of installing the usable CLI.This PR makes Tasks and Jobs independently installable and restores clean installation of current CLI-only releases.
What changed
tasksandjobsskills with Unix and PowerShell bootstraps.SHA256SUMS, installsarchdev, probes its domain capability, and returns an absolute executable path.install.sh,install.ps1, fixtures, and installer smoke assertions for CLI-only archives. Upgrades now remove a stale retired dashboard binary.Before → after:
npx skills add ... --skill tasks|jobsfinds no package → each domain installs independently with its own setup contract.Scope
Backend/tooling-only. No frontend code or user interface is changed.
Risk assessment
Medium. The skills are additive, but the change touches public installation paths on Unix and Windows. The Unix path was exercised against both fixtures and the live v0.33.2 release. Windows uses the same existing installer smoke workflow, but PowerShell was not available for local execution.
User impact
Agents can install only the Tasks or Jobs guidance they need. New CLI installs no longer fail because a retired dashboard binary is absent, and upgrades remove stale copies of that binary.
Testing
Canonical Tasks proof
tests/tasks-skill.shinstalls the Tasks skill through the realnpx skillspackage boundary in global and repository scopes, bootstraps a release archive into an isolated home, rejects a bad checksum, launches the installed executable as a separate process, and exercises an authenticated fenced task lifecycle. Its observable assertions verify claim/session reuse, room scope, dependency and link operations, and the absence of Jobs/setup side effects.Canonical Jobs proof
tests/jobs-skill.shinstalls the Jobs skill through the same real package boundary, verifies cold bootstrap and checksum rejection, launches the installed executable as a separate process, and exercises foreground plus durable job workflows. Its observable assertions cover logs, cancellation, retry, cleanup, runner and repository lifecycle, triggers, and the absence of authentication/provider side effects.Commands run
tests/tasks-skill.sh— passedtests/jobs-skill.sh— passedinstall.shagainst the public v0.33.2 CLI-only archive — passednpx skills add . --list— found both skillsgit diff --check— passedThe existing
installer-smoke-test.ymlworkflow runs automatically for pull requests on Ubuntu, macOS, and Windows and covers the modified public installers. The new skill acceptance scripts are currently manual-only; wiring public skill tests into CI is intentionally deferred.Follow-ups and known issues