Repository navigation
Remove turbo image - #13539
Merged
Merged
Remove turbo image#13539
Conversation
|
2 tasks
dylanjeffers
added a commit
that referenced
this pull request
Oct 19, 2026
…ss (#14678) ## Summary `MainActivity.onDestroy` emitted `ForceQuitDetected` through `reactInstanceManager.currentReactContext`. With the New Architecture on (1.5.189), `ReactActivityDelegate` builds its `ReactDelegate` from a `ReactHost` only. `ReactDelegate.getReactInstanceManager()` then throws `IllegalStateException("Cannot get ReactInstanceManager without a ReactNativeHost.")`, so every destroy that isn't a configuration change crashes the process. The likely trigger is the activity being destroyed while `MusicService` keeps the process alive: swiping the app out of Recents during playback, or the system reclaiming the activity in the background. Either way it kills playback. Nothing in JS has listened for `ForceQuitDetected` since #13539, so this removes the override (and its two imports) instead of porting it to `ReactHost`. Same class of bug as the RNTP bridgeless fix (#14647). This was the only other `reactInstanceManager` use in our Android sources, and the iOS sources have no bridge-only calls. ## Shipping It's a native-only change, so it ships in a native build. It's based on main, so it can go into a 1.5.189 rebuild if 1.5.189 isn't submitted yet, or otherwise into 1.5.190. Once 1.5.189 has some Android users, look in Play Console › Android vitals for `IllegalStateException` in `ReactDelegate.getReactInstanceManager` / `MainActivity.onDestroy` to confirm the impact. ## Test plan - [ ] Android release build: play a track, swipe the app out of Recents, and check logcat for `MainActivity.onDestroy` / `IllegalStateException` - [ ] Developer options › "Don't keep activities": background the app and return to it, with no crash 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think I trust the package enough for prod
duguyihou/react-native-turbo-image#425