Repository navigation
Unify the API for working with fonts when Pango is enabled. - #543
Closed
joefreeman wants to merge 2 commits into
Closed
joefreeman wants to merge 2 commits into
joefreeman wants to merge 2 commits into
Conversation
Closed
Collaborator
|
Hi @joefreeman, I'm sorry that this has fallen thru the cracks. Would you mind rebasing on master? I will make sure to review this. Thanks 👍 |
Contributor
Author
|
No need - looks like this is working in master now. I'll close this and my issue... |
Collaborator
|
@joefreeman Are you sure? Did you test it with built pango support? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to the discussion of issue #525, I've tried to make sure that the API works the same whether or not Pango is enabled. Previously, calling
addFontwith Pango enabled would cause the font rendering to break. Also, the font had to be referenced by family name. With this change, theaddFontcall is optional, but if it is called, the font can be referenced using the name provided to theFontconstructor.So, after setting up the font like this:
This:
Is equivalent to this (assuming the font's family name is 'My Font'):
But I'm not familiar with C++, Pango or Cairo, so my changes might be no good.