Repository navigation
Conversation
hjohn
requested review from
MGathier,
m1l4n54v1c and
trimoq
and removed request for
a team
October 27, 2026 15:53
NodeInfo.capabilities could only be populated when the NodeInfo happened to describe the node answering the request, so it was absent on every redirect - which is precisely when a client is left without a way to learn anything. Moved to PlatformInfo, where it unambiguously means "the capabilities of the node that answered this request" and is therefore always populated, redirect or not. A client that follows a redirect asks the next node for its own; a client that stops following already holds those of the node it is connected to.
hjohn
force-pushed
the
docs/node-capabilities-redirect
branch
from
October 27, 2026 16:14
d5b13c5 to
7026fd6
Compare
hjohn
changed the title
trimoq
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeInfo.capabilitiescould only be populated when theNodeInfohappened to describe the node answering the request. On a redirect it describes a different node, whose capabilities the answering node cannot know, so the field was left unset - which is precisely the case where a client is otherwise left with no way to learn anything.Moved to
PlatformInfo, where it unambiguously means "the capabilities of the node that answered this request" and is therefore always populated, redirect or not. A client that follows a redirect asks the next node for its own; a client that stops following already holds the capabilities of the node it is connected to.Removed from
NodeInfooutright rather than reserved, as the field has not been published.