Repository navigation
[#523] Minor FlowControlledReplyChannelWriter fix - loop while a completion is pending - #528
Merged
Merged
Conversation
Also loop while a completion is pending. A concurrent close() loses the flowGate CAS and returns, so the current gate holder is the only one left to send the completion.
smcvb
requested review from
MGathier,
hjohn,
m1l4n54v1c and
trimoq
and removed request for
a team
October 20, 2026 12:40
hjohn
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
FlowControlledReplyChannelWriteralso loops while a completion is pending.Otherwise, a concurrent
close()loses theflowGateCAS and returns, so the current gate holder is the only one left to send the completion. By doing the above, this PR addressed #523.