False positives for rule 1007 RemovedClientParameter when using typespec-autorest

Hi, I'm working on https://github.com/Azure/azure-rest-api-specs-pr/pull/15631 and there are a bunch of breaking changes reported for rule 1007. According to Azure/typespec-azure#3795 , these are false positives. Are these false positives? Can the rule be updated to eliminate these false positives?

How can I suppress these false positives? I've tried a few options without luck:

suppressions:
  - code: RemovedClientParameter
    reason: typespec-autorest puts the parameters in each operation
    from: vmware.json

directive:
  - suppress: RemovedClientParameter
    reason: typespec-autorest puts the parameters in each operation
    from: vmware.json

It sounds like these are not suppressible https://aka.ms/azsdk/pr-suppressions . Please update openapi-diff to not report these false positives.

Johan Stenberg (ex-msft) (@johanste)

From Johan Stenberg (ex-msft) (@johanste):

I just did a spot-check on the client parameter breaking change rule, and it seem to be ignoring the x-ms-parameter-location directive. In other words, it complaining about client parameters gone missing because the parameters as not in the parameters section should not complain if said parameter was explicitly marked as not being a client parameter.

Also reported here (nearly a year ago): Azure/azure-sdk-tools#5025

Navigation Menu

Repository navigation

False positives for rule 1007 RemovedClientParameter when using typespec-autorest #280

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

False positives for rule 1007 RemovedClientParameter when using typespec-autorest #280

Description

Activity

cataggar commented on Nov 3, 2023

cataggar commented on Nov 3, 2023

mikekistler commented on Nov 18, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions