Skip to content

Remove some flaky tests that were just an overkill - #5486

Merged
Gladwin Johnson VR (gladjohn) merged 1 commit into
mainfrom
gladjohn/flaky_test_device_code
Sep 19, 2025
Merged

Gladwin Johnson VR (gladjohn) merged 1 commit into
mainfrom
gladjohn/flaky_test_device_code

Conversation

@gladjohn

Copy link
Copy Markdown
Contributor

Fixes #5485

Changes proposed in this request
This pull request removes several integration tests related to device code flow scenarios from the DeviceCodeFlowIntegrationTest.cs file. The primary changes involve deleting tests for Arlington users, MSA users, and Azure AD Kerberos features, which streamlines the test suite in response to test failures.

Test removals:

  • Removed Arlington device code flow tests, including both standard and ADFS user scenarios.
  • Removed device code flow test for MSA users, which was previously marked as failing due to environment issues.

Kerberos feature test removal:

  • Removed the entire Azure AD Kerberos device code flow test region, including the main test method and its supporting helper function.

Testing
tests

Performance impact
n/a

Documentation

  • All relevant documentation is updated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes flaky and problematic integration tests from the device code flow test suite to improve test reliability. The changes streamline the test suite by eliminating tests that were causing failures or were deemed excessive.

  • Removes Arlington-specific device code flow tests (both standard and ADFS user scenarios)
  • Eliminates MSA (Microsoft Account) user device code flow test that was failing due to environment issues
  • Completely removes the Azure AD Kerberos feature test region including the main test method and helper function

@gladjohn
Gladwin Johnson VR (gladjohn) merged commit b111677 into main Sep 19, 2025
11 checks passed
@gladjohn
Gladwin Johnson VR (gladjohn) deleted the gladjohn/flaky_test_device_code branch September 19, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Engineering task] remove some flaky device code flow tests

4 participants