Android broker does not support adfs authority - #5522
Merged
Merged
Conversation
Gladwin Johnson VR (gladjohn)
approved these changes
Oct 6, 2025
…AndroidBrokerHelper.cs Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Gladwin Johnson VR (gladjohn)
approved these changes
Oct 7, 2025
fengga
enabled auto-merge (squash)
October 7, 2025 17:29
Contributor
Author
|
Oh, I need two reviewers |
Gladwin Johnson VR (gladjohn)
approved these changes
Oct 7, 2025
MARCIN Z (MZOLN)
approved these changes
Oct 7, 2025
| using (_logger.LogMethodDuration()) | ||
| { | ||
| // ADFS is not supported with broker | ||
| if (authorityType == AuthorityType.Adfs) |
There was a problem hiding this comment.
nit: I would have done smth like if (authorityType != AAD) { throw }
This was referenced Oct 24, 2025
Closed
Closed
Closed
This was referenced Nov 1, 2025
This was referenced Jun 5, 2026
Closed
Closed
This was referenced Jun 19, 2026
Closed
Closed
This was referenced Jun 29, 2026
Closed
This was referenced Jul 9, 2026
Closed
This was referenced Jul 16, 2026
Closed
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5017
Changes proposed in this request
Testing
Performance impact
Documentation