changed migrate_db.sh data to add PositionHistory, and added dummy da…#596
Merged
Conversation
…ta to demo_data.py
…nhistory info to change the primary key field so position code shows
…_peeweeAttribute Nahom dee alpha peewee attribute
nahom70
added
epic
MImran2002
requested changes
Jul 1, 2026
| Department = ForeignKeyField(Department) | ||
| Description = TextField(default=None) | ||
| Department = ForeignKeyField(Department) | ||
| PositionHistory._meta.set_primary_key('positioncode_revisiondate_status', CompositeKey('positioncode', 'revisiondate', 'status')) |
Contributor
There was a problem hiding this comment.
using like this is mores standard then doing positionhistoy.meta and so on. This is a tip, if you are implementing something in the model and it is different than usual implementation try looking at other models or even other repos like celts. Your method is another method but not the method SSDT does.
Contributor
There was a problem hiding this comment.
Another was the decision to have them as composite key discussed as I didn't see them on the board. Just want to make sure from my end.
MImran2002
requested changes
Jul 6, 2026
| Description = TextField(default=None) | ||
| Department = ForeignKeyField(Department) | ||
|
|
||
| class Meta: |
Contributor
There was a problem hiding this comment.
should be nested within positionhistory
MImran2002
requested changes
Jul 6, 2026
MImran2002
left a comment
MImran2002
left a comment
Contributor
There was a problem hiding this comment.
resolve the merge conflict
MImran2002
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing