Repository navigation
Use RandBLAS randomness in pivot-permutation tests - #197
Open
rileyjmurray wants to merge 1 commit into
Open
rileyjmurray wants to merge 1 commit into
rileyjmurray wants to merge 1 commit into
Conversation
Contributor
Author
|
This actually looks fine! Can merge once tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the existing pivot-permutation tests to draw their randomness through RandBLAS. Each permutation is formed by sorting sampled uniform keys, replacing the separate
std::mt19937_64/std::shufflepath. The reconstruction and pivot assertions are unchanged.This test-only refactor was extracted from #138 and is independent of the FunNyström++ implementation.
Validation. All 27 tests in
test_util.ccpassed locally with Spack Clang 19.1.3 and main's pinned RandBLAS revision.