[NO REVIEW] Repair assertions for LFortran - #353
Merged
Conversation
This picks up a critical improvement for LFortran 0.60 and later, to ensure preprocessor-rendered assertion expressions appear in the assertion message output.
The assert_callback_error_stop makes a bind(C) call to caf_fatal_error, which is currently miscompiled by LFortran, resulting in a segmentation fault (which fails to output the assertion information). Replace with a bare invocation of `error stop` for LFortran, as a temporary workaround until the compiler defect is repaired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion failure path for LFortran was previously hitting a segmentation fault (with no output). Consequently Caffeine's many assertion checks were not being correctly reported when triggered under LFortran.
Deploy fixes and workaround to ensure high-quality assertion failure output with LFortran.
CC: @Jainam-not-a-robot