Skip to content

Currently unusable on Mac due to the colors/theme, pref port action also a bit off #65

Description

@jdeltoft

image
This is what is looks like for me when running on Mac.

This is after I made a theme update per https://gist.github.com/gph03n1x/7281135

image

Activity

  1. jdeltoft commented on Apr 22, 2019

    @jdeltoft
    ContributorAuthor

    Also, when I start uPyloader when my preferred port isn't yet available, some other port is selected. But then this code was preventing my preferred port from having any action when I then turned on my nodemcu which was really the whole point of preferred port.

    image

    I updated it to use preferred port any time it's NEWLY found.

  2. BetaRavener commented on Apr 22, 2019

    @BetaRavener
    Owner

    I'll need to see about approving that dark theme PR - if it changes color scheme globally for everyone, not just those using dark theme, it would cause the same problems for other people.

    I wouldn't change preferred port behavior either. I can leave it open for discussion but that setting is meant mostly as start-up setting, not port auto-detection. It's disturbing to workflow if port always changes to the preferred one if you are working on a device that is not on that port (say you normally use wifi but want to debug using UART for a while).

    There's nothing wrong modifying uPyloader to your needs, I'm just not sure if that aligns with needs of majority of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions