Skip to content

feat(statics): onboard 99 new HoodETH stock tokens and OFC equivalents - #9371

Merged
prithvishet2503 merged 1 commit into
masterfrom
CECHO-1803
Jul 28, 2026
Merged

feat(statics): onboard 99 new HoodETH stock tokens and OFC equivalents#9371
prithvishet2503 merged 1 commit into
masterfrom
CECHO-1803

Conversation

@prithvishet2503

Copy link
Copy Markdown
Contributor

TICKET: CECHO-1803

@prithvishet2503
prithvishet2503 requested a review from a team as a code owner July 28, 2026 11:39
@linear-code

linear-code Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

CECHO-1803

@prithvishet2503

Copy link
Copy Markdown
Contributor Author

@claude review this PR and go through the ticket https://linear.app/bitgo/issue/CECHO-1803/onboarding-stock-tokens-on-robinhood-evm-next-100-candidates for checking the contract address

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Claude finished @prithvishet2503's task —— View job


PR Review: HoodETH Stock Tokens Onboarding ✅

Reviewed PR #9371 for onboarding 99 new HoodETH stock tokens and OFC equivalents.

Todo List:

  • Read and analyze modified files (base.ts, hoodethTokens.ts, ofcHoodethTokens.ts)
  • Fetch Linear ticket CECHO-1803 to get contract address requirements (WebFetch permission not granted)
  • Review code for consistency, formatting, and potential issues
  • Cross-reference available token information and provide comprehensive review feedback

Code Review Summary

Positive Findings:

  1. Correct Token Count: Exactly 99 new tokens added as stated in the PR title

    • 99 new erc20Token entries in hoodethTokens.ts
    • 99 matching ofcerc20 entries in ofcHoodethTokens.ts
    • 99 corresponding UnderlyingAsset enum entries in base.ts
  2. Consistent Structure: All token definitions follow the established patterns

    • Proper UUIDs for each token
    • Consistent decimals (18) across all tokens
    • Proper network assignment (Networks.main.hoodeth)
    • Correct feature flags (EVM_ERC20_TOKEN_FEATURES_EXCLUDE_SINGAPORE)
  3. No Duplicates: Verified no duplicate contract addresses in the new additions

  4. Proper OFC Mapping: OFC tokens correctly reference their HoodETH counterparts

    • Consistent naming pattern: ofchoodeth: prefix for OFC tokens
    • Proper UnderlyingAsset references pointing to hoodeth: assets
    • Correct underlyingChain: 'hoodeth' parameter

⚠️ Areas for Verification (Cannot verify due to Linear access limitation):

  1. Contract Address Verification: Unable to cross-reference contract addresses against the Linear ticket CECHO-1803. Recommend manual verification that all 99 contract addresses match the requirements in the ticket.

  2. Token Metadata Accuracy: Company names and symbols should be verified against official sources.

📝 Technical Details Reviewed:

  • File: modules/statics/src/base.ts (+99 lines)

    • Added 99 new UnderlyingAsset enum entries from 'hoodeth:wdc' to 'hoodeth:cats'
  • File: modules/statics/src/coins/hoodethTokens.ts (+992 lines)

    • Added 99 new stock token definitions with contract addresses
    • Sample tokens: WDC, ALAB, CRDO, AVAV, ADBE, WULF, FIG, SMR, KLAC, PL, etc.
  • File: modules/statics/src/coins/ofcHoodethTokens.ts (+1387 lines)

    • Added 99 corresponding OFC token definitions
    • Proper linking to HoodETH underlying assets

🚀 Recommendation:

APPROVE pending manual verification of contract addresses against Linear ticket CECHO-1803. The code structure, consistency, and implementation approach are sound and follow BitGoJS patterns correctly.

Next Steps:

  1. Verify contract addresses match Linear ticket requirements
  2. Run linting and tests if not already done
  3. Consider running integration tests for token validation

Branch: CECHO-1803 | Job: View Run

@prithvishet2503

Copy link
Copy Markdown
Contributor Author
⏺ All 99 hoodethTokens.ts entries match the ticket exactly (address + decimals), zero mismatches. Now checking base.ts and ofcHoodethTokens.ts.
                                                                                                                                                                                         
⏺ Read 1 file (ctrl+o to expand)                                                                                                  
                                                                                                                                                                                         
⏺ Validation complete. All 99 HoodETH tokens from Linear ticket CECHO-1803 are correctly onboarded across all three files:                                                               
                                                                                                                                                                                         
  - base.ts — all 99 UnderlyingAsset['hoodeth:*'] enum entries present                                                                                                                   
  - hoodethTokens.ts — all 99 erc20Token(...) entries present, addresses and decimals (18) match the ticket exactly, zero mismatches                                                     
  - ofcHoodethTokens.ts — all 99 ofcerc20(...) entries present, correctly reference their matching UnderlyingAsset, decimals correct, zero mismatches                                    
  
  Note: my earlier "missing: kss" result was a false negative — the regex assumed single-quoted names, but "Kohl's Corporation" is double-quoted in source to avoid escaping the         
  apostrophe. Fixed the regex to handle both quote styles; the entry itself is correct (0x12e3c047bf9aecaf9ddc98c05c31bfd1dd043993, matches ticket).

  No discrepancies found. Branch CECHO-1803 configs are correct per the ticket.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the @bitgo/statics coin registry to support additional Robinhood Chain (HoodETH) stock/ETF tokens and their OFC representations, enabling downstream SDK consumers to reference these assets via static definitions.

Changes:

  • Added 99 new HoodETH ERC-20 token definitions (including contract addresses and underlying-asset mappings).
  • Added corresponding OFC token definitions for the newly onboarded HoodETH assets.
  • Extended UnderlyingAsset with new hoodeth:* entries to back the new token registrations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
modules/statics/src/coins/ofcHoodethTokens.ts Adds OFC ERC-20 coin entries for newly onboarded HoodETH stock/ETF tokens.
modules/statics/src/coins/hoodethTokens.ts Adds new HoodETH ERC-20 token definitions (name, decimals, contract, underlying asset, and features).
modules/statics/src/base.ts Registers new UnderlyingAsset enum values required by the added HoodETH/OFC token entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@manojkumar138 manojkumar138 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown

Reviewed the diff — onboards 100 HoodETH stock tokens (enum in base.ts, entries in hoodethTokens.ts, matching OFC mirrors in ofcHoodethTokens.ts) for CECHO-1803.

Checks:

  • No duplicate GUIDs, tickers, or contract addresses — among the new entries or against the existing ones.
  • All addresses well-formed (0x + 40 hex), consistently lowercase to match the file's existing convention.
  • Decimals uniformly 18, consistent with the existing HoodETH tokens.
  • 1:1 parity between base tokens and their OFC mirrors — nothing orphaned.
  • Style and structure match the existing HoodETH batch exactly.

No blocking issues. CI green aside from unit/browser tests still running.


Generated by Claude Code

@prithvishet2503
prithvishet2503 merged commit 36cee9d into master Jul 28, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants