Repository navigation
fix(auth): protect rotated refresh tokens from stale runtime snapshots - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
A successful OAuth token refresh rotates the refresh token in accounts.json. If the active Codex auth.json still contains an older snapshot, the next reconciliation can overwrite the new token with the old, single-use refresh token. This makes switching back or refreshing later fail.
Fix
Extract the credential-generation safeguard from upstream PR Lampese#185 without importing the unrelated OAuth refresh policy overhaul:
Regression coverage
Four storage tests:
This patch is separated from upstream Lampese#185 because the full PR conflicts with our workspace-aware OAuth changes. Rust CI and platform compile checks are pending. Do not merge if they fail.