Repository navigation
fix(auth): serialize refresh and switching across desktop/web processes - #18
Merged
Merged
Conversation
Bl0ck154
marked this pull request as ready for review
October 28, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing AUTH_OPERATION_LOCK is a Tokio mutex within one process. When desktop Switcher and its web-server binary run at once, each process has its own mutex, so OAuth refresh and account switching can race across processes even though accounts.json itself now uses an atomic lock.
Fix
Tests
Add a current-thread async regression test: a second auth operation waits while the first holds the guard and proceeds after release. The existing storage tests cover filesystem lock serialization. No production account files or running processes are used by tests.
This is a focused extraction of upstream Lampese#185's cross-process-lock concept, integrated with our workspace-aware OAuth and atomic storage.
Draft until Rust CI and platform compile checks pass. No desktop release or VPS services are changed.