Repository navigation
fix(polymarket): a withdrawal that may have moved money is never signed twice - #174
Merged
Merged
Conversation
…ed twice A retry that resolved the earlier withdrawal now ends the call instead of signing another. The EOA rail signs locally and persists hash, nonce and bytes before the broadcast; only a receipt resolves it, and a retry re-broadcasts the same bytes. No time expiry and no nonce inference for a plain transaction. The relayer withdrawal is recorded before the submit. HTTP 408 is an unknown outcome, not a definite rejection.
The public reader and the write RPC can disagree on the pending pool; a reader nonce could collide with a transaction only the write node has seen and then wedge the guard behind a 'nonce too low'. prepareTransactionRequest now fills the nonce through the wallet's own transport, and that nonce is what gets persisted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirm:truecall signed a second transfer.isDefiniteRejection, which is shared by the CLOB submit, the relayer batch and fund.Test plan
npm test: 1394/1394npm run buildtest/polymarket-withdraw-eoa.test.tsandtest/polymarket-definite-rejection.test.ts. The withdraw and relayer tests were updated for the new lifecycle.