Skip to content

docs: mark the fixed security scan findings - #465

Open
hpmaxi wants to merge 2 commits into
tranche-3from
docs/scan-fixed-findings
Open

hpmaxi wants to merge 2 commits into
tranche-3from
docs/scan-fixed-findings

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Bottom of a stack. Merge order: #465 → #467 → #468 → #469 → #470 → #471. #464 is independent and best merged first, so each merge into tranche-3 gets a CI run.

Summary

Refs #434, #435, #445

No issue of its own: #458 left this update for one docs pull request once the related fixes merged, and #458 and #459 are now in tranche-3. The security scan still listed the three bugs it found or confirmed as open, with the fixes it planned at the time.

Changes

Deviations

  • The STRIDE update goes beyond the scan file. It keeps both documents in step, as the verifier event change does for its own row.

Acceptance criteria

  • No finding fixed by a merged pull request is still marked open in the security scan or the STRIDE threat model

Test plan

Automated tests

None: docs only.

Manual verification

  1. Open docs/SECURITY_SCAN.md on this branch.
  2. Search for "Open:".
  3. You should find no match, and the rows for A zero-share deposit refund can deadlock with its epoch's reconciliation #434, A stale NAV report cannot be replaced until the cooldown ends #435 and A zero-asset redemption from a delisted holder stays stuck and keeps its epoch open #445 should each name the pull request that fixed them.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Nov 18, 2026 5:30pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — d31ece51 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant