Fix Windows process fixtures and use Apache-licensed assertions - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows native-package validation failed after the bounded process runner correctly timed out: Windows PowerShell could be terminated during cold startup before publishing the PID file, and the fixture then tried to read that missing file. The existing native crash probe now publishes its live PID atomically and holds without output. The timeout test validates readiness before awaiting timeout, while preserving its three-second deadline, seven-second bound, cancellation-token checks and live process-tree termination proof. The production process runner is unchanged.
Replace FluentAssertions 8.11.0 in the three test projects with AwesomeAssertions 9.6.0, whose NuGet package and exact source license declare Apache-2.0. The resolved net10 dependency group adds no packages or paid activation mechanism. Test references are private, and the namespace migration preserves existing assertion calls. Development documentation records the licensing choice and update policy.
Validation:
Product version remains 0.1.0. Existing CI jobs, timeouts, assertions and receipt requirements are preserved. Merged as
af6a7ed84de4463097258f44199cbd1c6fbbc3c9after all 21 checks passed. The resulting main-push CI run 37203248412 passed all 21 checks, with no failed or skipped jobs. Its Windows suite passed 21/21, including the formerly failing case in 3.024 seconds; macOS passed 3/3. Digest-verified artifact receipts confirm 2,534/2,534 generic tests and 1/1 native gateway test, with zero failures, skips or other nonsuccess results. Authenticated main Windows and .NET logs contain no Xceed or Fluent Assertions warning.Source head:
9a070c032ab20f14493d24f39c87cb0923c87502; tested PR merge:135a13c80d3a84a864426041163b879f33ddba83; base:3884d322c9548aed99886ef87854d37e21bac80f. The actual main merge and tested PR merge have identical Git trees.