ci: drop unsupported Python 3.7/3.8 and mysql 5.7 from test matrix - #6
Merged
Conversation
actions/setup-python can no longer provision Python 3.7 on the ubuntu-latest (24.04) runner, causing every CI run to fail at the "Set up Python" step regardless of the actual code changes. Rather than pin an older runner image to keep 3.7/3.8 alive, align the matrix with what upstream (datajoint/element-array-ephys) already tests: Python 3.9 and 3.10 against mysql 8.0 only. Also picked up upstream's black check on notebooks/, and fixed the one pre-existing style violation it caught (a docstring black wants collapsed to a single line) so the check actually passes. Assisted-by: ClaudeCode:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Human guided, AI assisted PR (using this skill). AI text below. 🤖
Summary
Every CI run on this fork has been failing at the
Set up Python 3.7step:ubuntu-latestnow points at 24.04, which no longer ships/provisions Python 3.7 builds viaactions/setup-python. Because this matrix entry fails during setup, GitHub Actions cancels the rest of the matrix (3.8/3.9/3.10), so the wholeTestworkflow shows red on every push/PR regardless of the actual code changes — including PRs #2/#3/#4 that only touchedelement_array_ephys/readers/.Change
Instead of pinning an older runner image just to keep 3.7/3.8 alive, this aligns the matrix with what upstream (
datajoint/element-array-ephys) already tests:3.9,3.10only (dropped3.7,3.8)8.0only (dropped5.7)black notebooks --checkstep alongside the existingblack element_array_ephys --checkAlso fixed the one pre-existing style violation
black notebooks/black element_array_ephysactually caught once run locally against both target versions:element_array_ephys/plotting/corr.pyhad a docstringblackwants collapsed to a single line. Without this fix, the matrix would still fail even after removing the dead 3.7/3.8 entries.Verified locally (
black --checkfor bothelement_array_ephysandnotebooks, target versionspy39andpy310) that this now passes cleanly.Test plan
Testworkflow goes green on this PRAssisted-by: ClaudeCode:claude-sonnet-5