docs: fix upstream sync runbook defects found on first run - #35
Merged
Merged
Conversation
The first sync (#28) hit four problems running the runbook as written: - Step 0 used curl, which .claude/settings.json denies. Fetch the licence with gh api instead, quoted so zsh does not glob the '?', and add a size check so an empty fetch cannot pass for a gate failure. - Step 1's compare API call passed upstream/main, a local ref, and got a 404. GitHub needs main. Add the local git rev-list cross-check. - Adding a remote named upstream makes gh default to App-vNext/Polly, so the Step 3 report would go to Polly's tracker. Setup now pins gh repo set-default to Fences. - Dependabot group bumps do not match ADR 0003 D5's pattern. Document that they go to a person and are usually skip-with-reason; widening the automatic pattern is a D5 amendment, not a runbook edit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Step 4.2 told porters to rename PollyServiceCollectionExtensions to FencesServiceCollectionExtensions, a name fork-migration-plan.md explicitly rejected. The shipped class is ResilienceServiceCollectionExtensions. Also spell out the telemetry-name and path mappings a port has to apply. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
Added a fifth fix: Step 4.2 named the renamed DI class as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four defects in
.agent_instructions/upstream_sync.mdthat the first upstream sync (#28, sync report) hit when running the runbook as written.curl, which.claude/settings.jsondenies. Now usesgh api 'repos/App-vNext/Polly/contents/LICENSE?ref=main' --jq .content | base64 -d. The path is quoted: unquoted, zsh globs the?, the fetch silently never runs, and the empty file diffs like a gate failure. That happened on this run. Awc -cline now makes an empty fetch obvious.upstream/main, which is a local remote-tracking ref, so GitHub doesn't recognise it. Now usesmain. Also adds the localgit rev-listcross-check.ghwould have targeted Polly's repo. Once a clone has a remote namedupstream,gh issueandgh prresolve againstApp-vNext/Pollyby default, so Step 3's report would have gone to Polly's tracker. Setup now includesgh repo set-default BrighterCommand/Fences.Bump <dep> from <x> to <y>pattern. The runbook now says so explicitly: they go to a person and are usually skip-with-reason. The automatic pattern is not widened, because that would change an accepted ADR decision (D5), so it needs an amendment, not a runbook edit.No licence-gate rule changes, so per the runbook's own closing section this doesn't need a new ADR.
Verification
29ahead,0behind, matchinggit rev-list.markdownlint-cli2: 0 issues. Localpyspelling: no hits outside the two gitignored files.🤖 Generated with Claude Code