select: Fix perform_search to call SelectItem::matches (longbridg…

.gitignore

@@ -6,3 +6,4 @@ target/
 index.scip
 *.log
 node_modules/
+.ai_agents/

AGENTS.md

@@ -38,3 +38,17 @@ bd sync               # Sync with git
 - NEVER say "ready to push when you are" - YOU must push
 - If push fails, resolve and retry until it succeeds
 
+## Animation Guardrails (GPUI)
+
+- Failure mode: open animation flashes (open -> collapse -> open).
+- Root cause: using `bounce(...)` easing for reveal/size/opacity. `bounce` is forward-then-reverse; at `delta=1` it returns ~0, so the end frame collapses.
+- Rule: only use monotonic easings (fast_invoke/point_to_point/soft_dismiss) for reveal/size/opacity.
+- If you want “spring” feel: simulate with a snappier monotonic curve or staged animations; avoid `bounce` unless you want ping-pong.
+- Required pattern for open/close motion:
+  1. Keep `target_state` (source-of-truth open/closed).
+  2. Keep `visual_state` (mounted/visible during exit animation).
+  3. Compute `transition_active = target_changed || (visual_state != target_state)`.
+  4. Run `with_animation(...)` **only** when `transition_active`.
+  5. On close, delay `visual_state=false` until close duration elapses; guard timer with latest `target_state`.
+- For dialogs/surfaces: do not unmount on close request if animation enabled; mark as closing, remove after timer.
+- Reduced motion / `animate(false)`: bypass delay + animation, apply final state immediately.

Cargo.toml

@@ -13,6 +13,7 @@ members = [
     "examples/dialog_overlay",
     "examples/webview",
     "examples/system_monitor",
+    "examples/focus_trap",
 ]
 resolver = "2"
 
@@ -21,9 +22,9 @@ publish = false
 edition = "2024"
 
 [workspace.dependencies]
-gpui-component = { path = "crates/ui", version = "0.5.0" }
-gpui-component-macros = { path = "crates/macros", version = "0.5.0" }
-gpui-component-assets = { path = "crates/assets", version = "0.5.0" }
+gpui-component = { path = "crates/ui", version = "0.5.1" }
+gpui-component-macros = { path = "crates/macros", version = "0.5.1" }
+gpui-component-assets = { path = "crates/assets", version = "0.5.1" }
 story = { path = "crates/story" }
 
 gpui = { git = "https://github.com/BumpyClock/zed", rev = "b0ca6e65c7ae3ed7fafd03ce26f2d095bc002e31" }
@@ -93,3 +94,6 @@ ttf-parser = { opt-level = 3 }
 
 [workspace.metadata.typos]
 files.extend-exclude = ["**/fixtures/*"]
+
+[workspace.metadata.typos.default.extend-identifiers]
+consts = "consts"

LEARNINGS.md

@@ -1,13 +1,80 @@
 # Learnings
 
 ## 2026-01-22
-Context: restore glass styling for popup menus and selects.
-What I tried: wrapped menu content with SurfacePreset::flyout and used blur_enabled from GlobalState.
-Outcome: popover surfaces now handle opacity, border, elevation, and noise consistently.
-Next time: prefer SurfacePreset::flyout for popover containers and keep content styling separate.
+Context: popup/select glass surface styling and noise overlay consistency.
+What worked:
+- Use `SurfacePreset::flyout` on popover containers; keep content styling separate.
+- Read noise texture via `ImageSource::Resource(Resource::Embedded(...))`, not `img("...")`.
+Outcome: consistent opacity, border, elevation, and noise; no URI-loading failures.
+Next time: default to flyout preset + embedded resource images for non-URI assets.
 
-## 2026-01-22
-Context: noise asset failing to load for surface overlays.
-What I tried: used `img("NoiseAsset_256.png")` with gpui assets.
-Outcome: gpui treated the path as a URI; loading failed until using `ImageSource::Resource(Resource::Embedded(...))`.
-Next time: use explicit embedded resource sources for non-URI image assets.
+## 2026-02-10
+Context: command palette animation stability and quality.
+What worked:
+- Clamp/sanitize custom easing output to `[0, 1]` to avoid `delta should always be between 0 and 1`.
+- Stage motion: shell instant (`animate(false)`), then list/content reveal.
+- Keep container expand and child reveal aligned; avoid conflicting opacity/height phases on translucent surfaces.
+Outcome: no animation assert panic and cleaner open sequence without white flash.
+Next time: add regression test for overshoot cubic-bezier curves; keep dismiss curves simpler than entrance curves.
+
+## 2026-02-10
+Context: collapsible/accordion motion felt abrupt.
+What worked:
+- Keep content mounted during close (delayed commit), animate both open and close.
+- Use spring-style easing on open (`bounce(ease_in_out)`) and simpler close easing.
+Outcome: smoother sibling reflow and playful open without heavy dismiss.
+Next time: avoid conditional unmount when exit/layout animation is required.
+
+## 2026-02-10
+Context: command palette selection crash (`cannot update ... while it is already being updated`).
+What worked: in `cx.subscribe(...)` callbacks, update `this` directly; remove nested `view.update(...)` on the same entity.
+Outcome: no re-entrant lease panic; selection updates render normally.
+Next time: treat subscribe callbacks as the update scope; avoid nested entity updates.
+
+## 2026-02-10
+Context: command palette empty state clipping/blankness during expand.
+What worked:
+- Use dedicated `EMPTY_STATE_HEIGHT` instead of row `item_height`.
+- Top-align empty-state content (`pt_6`) instead of vertical centering.
+Outcome: icon/text render fully and appear earlier during expansion.
+Next time: design empty-state layout independently from row metrics when height is animated.
+
+## 2026-02-10
+Context: command palette still showed a blank strip under search before results reveal.
+What worked:
+- Make header row explicitly match `HEADER_HEIGHT` (`h + flex + items_center`) instead of relying on padding-only sizing.
+Outcome: collapsed shell height and header layout now match; removed mismatch strip.
+Next time: when using fixed layout constants, size the corresponding section explicitly to that constant.
+
+## 2026-02-10
+Context: blank strip persisted even after palette view-level fixes.
+What worked: override dialog default minimum height for command palette (`.min_h(px(0.))`), because `Dialog` enforces `.min_h_24()` by default.
+Outcome: command palette collapsed height now respects its own shell height during pre-reveal.
+Next time: when embedding compact overlays inside `Dialog`, explicitly set min-height if default dialog floor is too large.
+
+## 2026-02-10
+Context: sidebar and nested menu sections had snap-open/snap-close behavior.
+What worked:
+- animate sidebar width from a dedicated expanded width source (`Sidebar::width(...)`) instead of style-only width overrides.
+- keep a delayed visual-collapsed state so compact paddings/icon-only layout applies after close width animation.
+- keep submenu mounted during close and unmount after animation duration.
+Outcome: sidebar collapse/expand and submenu section open/close now animate as continuous layout motion; reduced-motion path remains instant.
+Next time: if caret icon rotation should animate, avoid coupling icon transform to `Button::icon(...)` and render a custom caret container with direct animation hook.
+
+## 2026-02-10
+Context: recurring motion regressions (snap-back, reopen-on-close, no-exit) across dialog/sidebar/accordion/popover.
+What worked:
+- Introduce shared keyed presence state machine in `animation::keyed_presence` (Entering/Entered/Exiting/Exited).
+- Use generation-guarded timers to ignore stale async transitions.
+- Drive render + animation from presence phase (`should_render`, `transition_active`, `progress`) instead of ad-hoc booleans.
+- For dropdown menus, delay menu entity reset until popover exit completes.
+Outcome: motion lifecycle is centralized; avoids per-component timer drift and repeated transition bugs.
+Next time: default new animated components to keyed presence first; avoid custom target/visible timer code.
+
+## 2026-02-10
+Context: open animations flashed (open -> collapse -> open) on Accordion/Sidebar/Dialog.
+What worked:
+- Remove `bounce(...)` easing from reveal/size/opacity transitions.
+- Use monotonic easings (fast_invoke/point_to_point) for open/close.
+Outcome: no end-frame collapse; open state stays stable.
+Next time: avoid `bounce` for reveal/size/opacity; it is forward-then-reverse.

README.md

@@ -25,7 +25,7 @@ UI components for building fantastic desktop applications using [GPUI](https://g
 
 ```toml
 gpui = "0.2.2"
-gpui-component = "0.5.0"
+gpui-component = "0.5.1"
 ```
 
 ### Basic Example

crates/assets/Cargo.toml

@@ -9,7 +9,7 @@ repository = "https://github.com/longbridge/gpui-component"
 readme = "README.md"
 edition.workspace = true
 publish = true
-version = "0.5.0"
+version = "0.5.1"
 
 [lib]
 doctest = false

crates/macros/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "gpui-component-macros"
 description = "Macros for GPUI Component."
-version = "0.5.0"
+version = "0.5.1"
 license = "Apache-2.0"
 publish = true
 edition.workspace = true
@@ -18,4 +18,4 @@ quote = "1.0"
 syn = "2.0"
 
 [package.metadata.cargo-machete]
-ignored = ["proc-macro2"]
+ignored = ["proc-macro2", "core-text"]

crates/reqwest_client/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "reqwest_client"
-version = "0.5.0"
+version = "0.5.1"
 license = "Apache-2.0"
 publish = false
 edition.workspace = true

crates/story/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "gpui-component-story"
-version = "0.5.0"
+version = "0.5.1"
 publish = false
 edition.workspace = true
 

crates/story/examples/editor.rs

@@ -74,6 +74,7 @@ pub struct Example {
     line_number: bool,
     indent_guides: bool,
     soft_wrap: bool,
+    show_whitespaces: bool,
     lsp_store: ExampleLspStore,
     _subscriptions: Vec<Subscription>,
     _lint_task: Task<()>,
@@ -728,6 +729,7 @@ impl Example {
             line_number: true,
             indent_guides: true,
             soft_wrap: false,
+            show_whitespaces: false,
             lsp_store,
             _subscriptions,
             _lint_task: Task::ready(()),
@@ -987,6 +989,25 @@ impl Example {
             }))
     }
 
+    fn render_show_whitespaces_button(
+        &self,
+        _: &mut Window,
+        cx: &mut Context<Self>,
+    ) -> impl IntoElement {
+        Button::new("show-whitespace")
+            .ghost()
+            .xsmall()
+            .when(self.show_whitespaces, |this| this.icon(IconName::Check))
+            .label("Show Whitespaces")
+            .on_click(cx.listener(|this, _, window, cx| {
+                this.show_whitespaces = !this.show_whitespaces;
+                this.editor.update(cx, |state, cx| {
+                    state.set_show_whitespaces(this.show_whitespaces, window, cx);
+                });
+                cx.notify();
+            }))
+    }
+
     fn render_indent_guides_button(
         &self,
         _: &mut Window,
@@ -1079,6 +1100,7 @@ impl Render for Example {
                                     .gap_3()
                                     .child(self.render_line_number_button(window, cx))
                                     .child(self.render_soft_wrap_button(window, cx))
+                                    .child(self.render_show_whitespaces_button(window, cx))
                                     .child(self.render_indent_guides_button(window, cx)),
                             )
                             .child(self.render_go_to_line_button(window, cx)),