[Build] Update GPUI dependency - #3
Merged
Merged
Conversation
Summary by CodeRabbit
WalkthroughAdds YAML frontmatter (mainly Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 2/5 reviews remaining, refill in 26 minutes and 16 seconds. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the repository to a newer gpui/gpui_platform git revision, updates the lockfile accordingly, and applies small compatibility adjustments plus docs/typos config updates to match the upstream vendored GPUI state.
Changes:
- Bump
gpuiandgpui_platformgit revs and refreshCargo.lockfor the new dependency graph. - Update UI code for upstream type changes (scrollbar content-size math) and address clippy enum-size lint by boxing
SettingItem’s control field. - Add/standardize VitePress-style frontmatter summaries across docs and exclude
vendor/gpui/fromtypos.
Reviewed changes
Copilot reviewed 85 out of 87 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| typos.toml | Excludes vendored GPUI from spellchecking. |
| docs/skills.md | Adds frontmatter summary for docs site metadata. |
| docs/learned/theme-motion.md | Adds learned-doc frontmatter metadata. |
| docs/learned/spring-preset-api.md | Adds learned-doc frontmatter metadata. |
| docs/learned/sidebar-animation.md | Adds learned-doc frontmatter metadata. |
| docs/learned/menu-popover-animation.md | Adds learned-doc frontmatter metadata. |
| docs/learned/gpui-submodule.md | Adds learned-doc frontmatter metadata. |
| docs/learned/command-palette-animation.md | Adds learned-doc frontmatter metadata. |
| docs/learned/asset-source-composition.md | Moves read_when into frontmatter and adds summary metadata. |
| docs/learned/accordion-animation.md | Adds learned-doc frontmatter metadata. |
| docs/learned/LEARNINGS.md | Adds index frontmatter metadata for learned docs. |
| docs/index.md | Adds home page title/summary metadata. |
| docs/docs/theme.md | Adds docs page title/summary metadata. |
| docs/docs/root.md | Adds docs page title/summary metadata. |
| docs/docs/installation.md | Adds docs page summary metadata. |
| docs/docs/index.md | Adds docs page summary metadata. |
| docs/docs/getting-started.md | Adds docs page summary metadata. |
| docs/docs/element_id.md | Adds docs page summary metadata. |
| docs/docs/context.md | Adds docs page summary metadata. |
| docs/docs/components/virtual-list.md | Adds component page summary metadata. |
| docs/docs/components/tree.md | Adds component page summary metadata. |
| docs/docs/components/tooltip.md | Adds component page summary metadata. |
| docs/docs/components/toggle.md | Adds component page summary metadata. |
| docs/docs/components/title-bar.md | Adds component page summary metadata. |
| docs/docs/components/tag.md | Adds component page summary metadata. |
| docs/docs/components/tabs.md | Adds component page summary metadata. |
| docs/docs/components/table.md | Adds component page summary metadata. |
| docs/docs/components/switch.md | Adds component page summary metadata. |
| docs/docs/components/stepper.md | Adds component page summary metadata. |
| docs/docs/components/spinner.md | Updates description text and adds summary metadata. |
| docs/docs/components/slider.md | Adds component page summary metadata. |
| docs/docs/components/skeleton.md | Adds component page summary metadata. |
| docs/docs/components/sidebar.md | Adds component page summary metadata. |
| docs/docs/components/sheet.md | Adds component page summary metadata. |
| docs/docs/components/settings.md | Adds component page summary metadata. |
| docs/docs/components/select.md | Adds component page summary metadata. |
| docs/docs/components/scrollable.md | Adds component page summary metadata. |
| docs/docs/components/resizable.md | Adds component page summary metadata. |
| docs/docs/components/rating.md | Adds component page summary metadata. |
| docs/docs/components/radio.md | Adds component page summary metadata. |
| docs/docs/components/progress.md | Adds component page summary metadata. |
| docs/docs/components/popover.md | Adds component page summary metadata. |
| docs/docs/components/plot.md | Adds component page summary metadata. |
| docs/docs/components/pagination.md | Adds component page summary metadata. |
| docs/docs/components/otp-input.md | Adds component page summary metadata. |
| docs/docs/components/number-input.md | Adds component page summary metadata. |
| docs/docs/components/notification.md | Adds component page summary metadata. |
| docs/docs/components/menu.md | Adds component page summary metadata. |
| docs/docs/components/list.md | Adds component page summary metadata. |
| docs/docs/components/label.md | Adds component page summary metadata. |
| docs/docs/components/kbd.md | Adds component page summary metadata. |
| docs/docs/components/input.md | Adds component page summary metadata. |
| docs/docs/components/index.md | Adds components index summary metadata. |
| docs/docs/components/image.md | Adds component page summary metadata. |
| docs/docs/components/icon.md | Adds component page summary metadata. |
| docs/docs/components/hover-card.md | Adds component page summary metadata. |
| docs/docs/components/group-box.md | Adds component page summary metadata. |
| docs/docs/components/form.md | Adds component page summary metadata. |
| docs/docs/components/focus-trap.md | Adds component page summary metadata. |
| docs/docs/components/editor.md | Adds component page summary metadata. |
| docs/docs/components/dropdown_button.md | Adds component page summary metadata. |
| docs/docs/components/dialog.md | Fixes description wording and adds summary metadata. |
| docs/docs/components/description-list.md | Adds component page summary metadata. |
| docs/docs/components/date-picker.md | Adds component page summary metadata. |
| docs/docs/components/color-picker.md | Adds component page summary metadata. |
| docs/docs/components/collapsible.md | Adds component page summary metadata. |
| docs/docs/components/clipboard.md | Adds component page summary metadata. |
| docs/docs/components/checkbox.md | Adds component page summary metadata. |
| docs/docs/components/chart.md | Adds component page summary metadata. |
| docs/docs/components/calendar.md | Adds component page summary metadata. |
| docs/docs/components/button.md | Adds component page summary metadata. |
| docs/docs/components/badge.md | Adds component page summary metadata. |
| docs/docs/components/avatar.md | Adds component page summary metadata. |
| docs/docs/components/alert.md | Adds component page summary metadata. |
| docs/docs/components/accordion.md | Adds component page summary metadata. |
| docs/docs/assets.md | Adds docs page summary metadata. |
| docs/contributors.md | Adds contributors page title/summary metadata. |
| docs/README.md | Adds docs README frontmatter metadata. |
| crates/ui/src/setting/item.rs | Boxes SettingControl inside SettingItem::Item and updates constructor accordingly. |
| crates/ui/src/scroll/scrollbar.rs | Adapts ListState content-size calculation to upstream geometry typing (into()). |
| Cargo.toml | Updates gpui/gpui_platform git rev pins. |
| Cargo.lock | Refreshes lockfile for new GPUI rev and transitive dependency updates. |
| .tasque/events.jsonl | Clears tracked Tasque event log contents. |
| .tasque/config.json | Adds Tasque sync_branch configuration. |
| .gitattributes | Adds merge driver attribute for .tasque/events.jsonl. |
| .claude/skills/github-pull-request-description/SKILL.md | Fixes a spelling error (“prefer”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/index.md`:
- Line 4: Update the YAML summary value for the key "summary" so the user-facing
copy reads "Rust GUI components for building fantastic cross-platform desktop
applications by using GPUI." — specifically change "desktop application" to
"desktop applications" in the existing summary string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5e38f5cb-7d7d-466b-b4db-11ca3cad7652
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (86)
.claude/skills/github-pull-request-description/SKILL.md.gitattributes.tasque/config.json.tasque/events.jsonlCargo.tomlcrates/ui/src/scroll/scrollbar.rscrates/ui/src/setting/item.rsdocs/README.mddocs/contributors.mddocs/docs/assets.mddocs/docs/components/accordion.mddocs/docs/components/alert.mddocs/docs/components/avatar.mddocs/docs/components/badge.mddocs/docs/components/button.mddocs/docs/components/calendar.mddocs/docs/components/chart.mddocs/docs/components/checkbox.mddocs/docs/components/clipboard.mddocs/docs/components/collapsible.mddocs/docs/components/color-picker.mddocs/docs/components/date-picker.mddocs/docs/components/description-list.mddocs/docs/components/dialog.mddocs/docs/components/dropdown_button.mddocs/docs/components/editor.mddocs/docs/components/focus-trap.mddocs/docs/components/form.mddocs/docs/components/group-box.mddocs/docs/components/hover-card.mddocs/docs/components/icon.mddocs/docs/components/image.mddocs/docs/components/index.mddocs/docs/components/input.mddocs/docs/components/kbd.mddocs/docs/components/label.mddocs/docs/components/list.mddocs/docs/components/menu.mddocs/docs/components/notification.mddocs/docs/components/number-input.mddocs/docs/components/otp-input.mddocs/docs/components/pagination.mddocs/docs/components/plot.mddocs/docs/components/popover.mddocs/docs/components/progress.mddocs/docs/components/radio.mddocs/docs/components/rating.mddocs/docs/components/resizable.mddocs/docs/components/scrollable.mddocs/docs/components/select.mddocs/docs/components/settings.mddocs/docs/components/sheet.mddocs/docs/components/sidebar.mddocs/docs/components/skeleton.mddocs/docs/components/slider.mddocs/docs/components/spinner.mddocs/docs/components/stepper.mddocs/docs/components/switch.mddocs/docs/components/table.mddocs/docs/components/tabs.mddocs/docs/components/tag.mddocs/docs/components/title-bar.mddocs/docs/components/toggle.mddocs/docs/components/tooltip.mddocs/docs/components/tree.mddocs/docs/components/virtual-list.mddocs/docs/context.mddocs/docs/element_id.mddocs/docs/getting-started.mddocs/docs/index.mddocs/docs/installation.mddocs/docs/root.mddocs/docs/theme.mddocs/index.mddocs/learned/LEARNINGS.mddocs/learned/accordion-animation.mddocs/learned/asset-source-composition.mddocs/learned/command-palette-animation.mddocs/learned/gpui-submodule.mddocs/learned/menu-popover-animation.mddocs/learned/sidebar-animation.mddocs/learned/spring-preset-api.mddocs/learned/theme-motion.mddocs/skills.mdtypos.tomlvendor/gpui
💤 Files with no reviewable changes (1)
- .tasque/events.jsonl
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/index.md`:
- Around line 3-4: Update the front-matter key `description` so its wording
matches `summary`: change "Rust GUI components for building fantastic
cross-platform desktop application by using GPUI." to use plural "desktop
applications" and "using GPUI" (same style as `summary`), ensuring `description`
and `summary` are consistent in docs/docs/index.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 123d76b1-4e82-4bad-accd-6d675c7f059f
📒 Files selected for processing (2)
.gitattributesdocs/docs/index.md
Comment on lines
3
to
+4
| description: Rust GUI components for building fantastic cross-platform desktop application by using GPUI. | ||
| summary: "Rust GUI components for building fantastic cross-platform desktop applications using GPUI." |
There was a problem hiding this comment.
Fix user-facing copy inconsistency in front-matter (description).
summary (line 4) correctly uses “desktop applications” and “using GPUI”, but description (line 3) still says “desktop application” and “by using GPUI”. For consistency, update description to match the wording style of summary.
✏️ Proposed edit
-description: Rust GUI components for building fantastic cross-platform desktop application by using GPUI.
+description: Rust GUI components for building fantastic cross-platform desktop applications using GPUI.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| description: Rust GUI components for building fantastic cross-platform desktop application by using GPUI. | |
| summary: "Rust GUI components for building fantastic cross-platform desktop applications using GPUI." | |
| description: Rust GUI components for building fantastic cross-platform desktop applications using GPUI. | |
| summary: "Rust GUI components for building fantastic cross-platform desktop applications using GPUI." |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/docs/index.md` around lines 3 - 4, Update the front-matter key
`description` so its wording matches `summary`: change "Rust GUI components for
building fantastic cross-platform desktop application by using GPUI." to use
plural "desktop applications" and "using GPUI" (same style as `summary`),
ensuring `description` and `summary` are consistent in docs/docs/index.md.
This was referenced Jul 15, 2026
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
gpuiandgpui_platformto0d952efcd0e8769b18acc0b15130c45dec80cab8, refreshes the lockfile, and applies compatibility fixes required by the upstream sync.Changes
vendor/gpuisubmodule.SettingItemcontrol storage to satisfy clippy enum-size lint.Breaking Changes
SettingItem::Item.fieldis now boxed.Testing
cargo buildcargo fmt --checkcargo clippy -- --deny warningstyposcargo machete Cargo.toml crates examples