[Build] Sync GPUI to 24cfa81 - #4
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
Summary by CodeRabbit
WalkthroughThe PR updates the pinned GPUI revision and Rust toolchain, makes flex sizing explicit across UI components, and aligns render and fluent-builder API usage in the field, webview, and example code. ChangesGPUI update
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update GPUI from
510dedc3b44fcf80c791ab17e59530ae66e80558to24cfa81ca2a9f954b96320e14b393dd519078618and keep the workspace dependency pins, lockfile, andvendor/gpuisubmodule in sync.This also applies the compatibility changes required by the newer GPUI API:
std::hint::cold_pathusage;1.0grow/shrink factors, preserving the former zero-argument behavior;AnyViewtointo_any_element();FluentBuilderexplicitly.How to Test
cargo fmt --checkcargo build --lockedcargo clippy --locked -- --deny warningsCARGO_BUILD_JOBS=2 cargo check --locked -p webview --all-targets --all-featurescargo metadata --locked --format-version 1Checklist
cargo runfor story tests related to the changes — not run; this is a dependency/build compatibility update with no visual behavior change.Review Notes
The lockfile intentionally includes GPUI's move from the WGPU git revision to crates.io WGPU 29.0.4. Existing fork-specific overlay and blur behavior remains in the pinned GPUI revision.