Skip to content

flags: fix broken roff bold markup in --null-data docs - #3553

Open
ump45nose wants to merge 1 commit into
BurntSushi:masterfrom
ump45nose:fix-null-data-man-bold
Open

ump45nose wants to merge 1 commit into
BurntSushi:masterfrom
ump45nose:fix-null-data-man-bold

Conversation

@ump45nose

@ump45nose ump45nose commented Oct 14, 2026 •

Copy link
Copy Markdown

The long help for --null-data (crates/core/flags/defs.rs:5407) opens bold with \fP instead of \fB:

of the default of \fP\\n\fP.

\fP restores the previous font; with no preceding \fB on that line it's a no-op, so \\n renders un-bolded in the generated man page. Every other reference to \\n in this file uses the correct \fB\\n\fP pair, and this is the only \fP\\ in the whole crate.

Repro (verified locally):

  • Before: rg --generate man emitted of the default of \fP\\n\fP.
  • After: of the default of \fB\\n\fP. (grep '\fP\\n' on generated man → 0 matches)

Help-text/markup change only; no behavior change. cargo build clean.


Disclosure per the AI Policy: this PR came out of an automated agent session. The agent spotted the mismatched roff escape, made the one-character edit, and ran rg --generate man before and after to produce the repro above; it also wrote the text above rather than me restating it in my own words. The policy says autonomous agents are not allowed to contribute here, so I am surfacing that instead of leaving it implicit — closing this is a reasonable outcome if it does not meet the bar. The claim is reproducible from a clean checkout: cargo run -- --generate man | grep '\\fP\\\\n' matches on master and not after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant