Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long help for
--null-data(crates/core/flags/defs.rs:5407) opens bold with\fPinstead of\fB:\fPrestores the previous font; with no preceding\fBon that line it's a no-op, so\\nrenders un-bolded in the generated man page. Every other reference to\\nin this file uses the correct\fB\\n\fPpair, and this is the only\fP\\in the whole crate.Repro (verified locally):
rg --generate manemittedof the default of \fP\\n\fP.of the default of \fB\\n\fP.(grep '\fP\\n'on generated man → 0 matches)Help-text/markup change only; no behavior change.
cargo buildclean.Disclosure per the AI Policy: this PR came out of an automated agent session. The agent spotted the mismatched roff escape, made the one-character edit, and ran
rg --generate manbefore and after to produce the repro above; it also wrote the text above rather than me restating it in my own words. The policy says autonomous agents are not allowed to contribute here, so I am surfacing that instead of leaving it implicit — closing this is a reasonable outcome if it does not meet the bar. The claim is reproducible from a clean checkout:cargo run -- --generate man | grep '\\fP\\\\n'matches on master and not after the change.