Repository navigation
searcher: add LineStep::advance_to - #3580
Open
samanyudas wants to merge 2 commits into
Open
samanyudas wants to merge 2 commits into
samanyudas wants to merge 2 commits into
Conversation
Closes BurntSushi#1618 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
advance_to(pos)to set the position ofLineStepwithout reading each line.posis inside a line, the next call returns the rest of that line.posis before the current position, the iterator returns lines again.posequals the configured end, iteration stops.posexceeds the configured end, the method panics.Tests check these cases and compare the results with a new iterator.
Formatting checks, tests, and documentation generation passed in the earlier local run.
I used AI to help write the code, tests, and this description.
I reviewed the changes and understand how they work.
Closes #1618.