Add send events - #11
Merged
Merged
Conversation
tdgroot
approved these changes
Sep 2, 2026
martijneichelsheim
approved these changes
Sep 2, 2026
ikidnapmyself
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every event we send opens a fresh connection to RabbitMQ, shakes hands, sends one message, then closes it again. Fine for one event, silly for four hundred, where we spend most of the time on hellos and goodbyes instead of actually sending anything.
So there is now a send_events(): one connection, whole batch through it. The same messages come out the other end. send_event() now just calls send_events([event]) so there is only one publish path to keep working.