Repository navigation
fix: error with cyvcf2>0.32 when loading a VCF/PVAR w/o --region - #284
Merged
Merged
Conversation
…n is not specified thanks to @mrkylesmith for identifying this!
aryarm
changed the title
--region--region and update to py3.11
aryarm
changed the title
--region and update to py3.11--region
aryarm
marked this pull request as ready for review
October 14, 2026 21:54
aryarm
commented
Oct 14, 2026
aryarm
commented
Oct 14, 2026
Co-authored-by: Arya Massarat <23412689+aryarm@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
Author
|
hoorah! 🎊 thanks for checking, kyle! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles a backwards-incompatible change in versions of
cyvcf2> 0.32.0, which was causing somewhat non-deterministic errors forhaptoolsusers. It also updates our internal development version to py3.11, the oldest version of python which is not end-of-life.Big thanks to @mrkylesmith for identifying this bug and its solution!
More details about the
cyvcf2change can be found here:https://github.com/brentp/cyvcf2/blob/main/CHANGES.md#v0320
brentp/cyvcf2@a1e1220