Conversation
The entry cited a cfdemSimulate doc note that is being removed from the documentation; state the fact (either side may survive a crash) directly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
marniemann
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the strategy "Track the actual launch's PIDs before trusting a coupled run has ended" so it states the fact itself: DEM and CFD are separate OS processes, and when one side aborts the other does not necessarily terminate (in either direction). Check both PIDs (
pgrep -a aspherix,pgrep -a cfdemSolver) before restarting or reusing a case's output directories.Why
The entry cited a note on
cfdemSimulate.htmlabout process independence. That note was removed from the documentation at review (CFDEMproject/AspherixCFDEM#1098), so the entry would point at text that no longer exists. Guidance on handling failures belongs in the skill rather than the user docs.Scope
One entry in
references/strategies/STRATEGIES.md(1 line replaced by 2). No new entry:portOffsethandling (cfdemSimulateremoves the files by default) andportFilePathare already covered by the docs andreferences/commands/cfdemSimulate.md.Tests
Skill text only; nothing to run.
Risks
None. The "either direction" statement comes from the #1098 review, not from a reproduction.
Rollout / rollback
Revert the commit.
🤖 Generated with Claude Code