Repository navigation
Conversation
…days A Brussels workspace had its follow-up delay counted on the French calendar: due on 21 July (Belgian national day) and shifted by a day around 14 July and 8 May, while meeting slots and the docs already used the workspace's country. The follow-up worker now reads the workspace timezone from inbox_features and the business-day helpers take it (default Europe/Paris). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up delays ("N business days without a reply") always used the French holiday calendar, even for a workspace set to
Europe/Brussels. Meeting slots (#104) andinbox-calendar-labels.mdalready claimed "same calendar as follow-up business days", which was not true for Belgium.Effect for a Belgian workspace: a follow-up could be prepared on 21 July (Belgian national day), and delays were off by one day around 14 July and 8 May (French-only holidays).
Change
followups/calendar.ts:isBusinessDay,addBusinessDays,followupDueAt,businessDaysBetweentake the workspace timezone (defaultEurope/Paris) and useisPublicHoliday. Paris and Brussels share offsets and DST rules, so only the holiday list differs.decideFollowup/FollowupSettings: optionaltimezone, passed through by the tracker.postgresFollowupStore.settings(): readsinbox_features.timezone(anything other thanEurope/Brussels→Europe/Paris).followups-pipeline-report.mdupdated;docs/TODO.mdentry.No migration. No UI change. No live service called.
Checks
calendar.test.tsanddetect.test.ts; both fail on the old code.tsc --noEmitOK,pnpm test1169/1169, eslint onsrc/lib/followupsclean,next build --webpackOK.NOBYPASSRLSapp role: Brussels workspace →Europe/Brussels, workspace without a row →Europe/Paris, another tenant's member reading it → RLS hides the row →Europe/Paris.Stacked on #104.
Generated by Claude Code