Skip to content

Strip trailing semicolon on the unlimited query() path across connectors #2497

Closed

Description

@goldmedal

Context

Follow-up to #2441 / #2480 (shared strip_trailing_semicolon in connector/base.py).

Several connectors strip the trailing ; only when a limit is supplied (the LIMIT subquery-wrap path). When query() runs with no limit, the SQL is passed through verbatim, so SELECT 1; reaches the engine unstripped. This issue tracks auditing every connector's no-limit path and routing it through the shared helper, in one PR.

Prerequisite: blocked by #2480 — rebase onto it so each change is "import + one call", not a new local copy.

Scope

Connectors with an existing PR — fold in and close

Connectors with no existing PR (net-new work)

Use the shared helper — don't add local copies

spark — and bigquery/mssql/snowflake — are not migrated by #2480, so their entries here must import strip_trailing_semicolon from base, not introduce a per-connector _strip_trailing_semicolon.

Related, evaluate separately (not pure semicolon fixes)

Done when

  • Every connector strips on both limited and unlimited query paths via the shared helper
  • Listed PRs folded in and closed; trino/mysql no-limit path covered

Activity

  1. goldmedal commented on Aug 11, 2026

    @goldmedal
    CollaboratorAuthor

    All tasks completed. Thanks @Bartok9 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    corepythonPull requests that update Python code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions