Repository navigation
chore(wren-ai-service): separate the api key for each LLM and embedder - #917
Merged
Merged
Conversation
paopa
marked this pull request as ready for review
November 15, 2024 12:20
Author
|
@cyyeh I've tried to leave an empty key when langfuse enabling. langfuse client disables itself when key is none or empty string. thus i think we can keep the setting default as true. here is the source code of langfuse if not self.enabled:
self.log.warning(
"Langfuse client is disabled. No observability data will be sent."
)
elif not public_key:
self.enabled = False
self.log.warning(
"Langfuse client is disabled since no public_key was provided as a parameter or environment variable 'LANGFUSE_PUBLIC_KEY'. See our docs: https://langfuse.com/docs/sdk/python/low-level-sdk#initialize-client"
)
elif not secret_key:
self.enabled = False
self.log.warning(
"Langfuse client is disabled since no secret_key was provided as a parameter or environment variable 'LANGFUSE_SECRET_KEY'. See our docs: https://langfuse.com/docs/sdk/python/low-level-sdk#initialize-client"
) |
Author
Migration Guide for Developers Using Docker ComposeAfter merging PR #792 and this one, follow these steps to update your configuration:
For more detailed information, please refer to the How to Start with OpenAI section in the Docker README. |
pull Bot
pushed a commit
to nagyist/WrenAI
that referenced
this pull request
May 4, 2026
…lan for unparsing (Canner#917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a clear separation between API keys used for LLM and Embedder services.
Changes
OPENAI_API_KEYintoLLM_OPENAI_API_KEYandEMBEDDER_OPENAI_API_KEYAZURE_OPENAI_API_KEYintoLLM_AZURE_OPENAI_API_KEYandEMBEDDER_AZURE_OPENAI_API_KEYImplementation Details
Environment Variables
Provider Updates
LLM_OPENAI_API_KEYEMBEDDER_OPENAI_API_KEYDeployment Changes