Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was done in support of CesiumGS/cesium-unreal#1891, although I acknowledge the connection is not obvious.
CesiumGltfcontained various utility classes for accessing metadata from a model'sEXT_structural_metadata. However,CesiumGltfintended to be scoped as a lightweight glTF reader, per discussion in #760, and has suffered from some bloat over the years.Although
CesiumGltfContentwas introduced for involved interaction/manipulation of glTF models, metadata is more special due to the overlap with 3D Tiles. In particular, the schemas between tilesets and glTF models withEXT_structural_metadataare identical in structure, but have unfortunate duplication between the generated spec classes. This overlap may be resolved with glTF 2.1, but even so, we may need to keep theCesium3DTilescounterparts to parse older tileset versions.Thus, this PR implements the suggestion in #760 to create a
CesiumMetadatalibrary for all the metadata-related classes.Issue number or link
N/A
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
TODO: Unreal/Unity PRs that implement the changes without breaking.
Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.