Prompt for release prep steps - #1443
Merged
Merged
Conversation
j9liu
self-requested a review
September 21, 2026 17:51
j9liu
reviewed
Sep 23, 2026
j9liu
left a comment
j9liu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @laurenfrederick ! Just two small comments from me.
|
|
||
| ## Prepare for Release | ||
|
|
||
| Run the `/prepare-release` skill in [.github/skills/prepare-release/SKILL.md](../../.github/skills/prepare-release/SKILL.md) and provide the release version number. It performs the first four steps for you: |
Collaborator
There was a problem hiding this comment.
The documentation build is failing because ../.github/skills/prepare-release/SKILL.md is not included in the known paths. You can add it to the docs/CMakeLists.txt under doxygen_add_docs.
However, doing so makes the page look like so:
I'm not sure how useful it is to view it that way -- I kinda prefer seeing it on the GitHub site itself, since it's GH specific, so maybe this could link to https://github.com/CesiumGS/cesium-native/tree/main/.github/skills/prepare-release/SKILL.md. But up to you what you think is most useful!
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
The local mesh variable was constructed but never read, so it served no purpose. It could not simply be optimized away, though: draco::Mesh has an out-of-line constructor and a non-trivial destructor defined inside the Draco library, so the compiler must still emit the construction/destruction across the shared-library boundary. Removing the unused variable eliminates that unnecessary overhead.
Collaborator
|
Thanks @laurenfrederick ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub Copilot Prompt for the release preparation steps.
< !-- Provide context for the reviewer to understand the pull request. Include what changes were made and why. -->
Issue number or link
#1441
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Remaining Tasks
Testing plan
Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.