Conversation
Author
|
For context I discovered that one trying to sample altitude on a freshly updated to v1.1 local tileset. |
j9liu
self-requested a review
September 28, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IntersectionTests::rayOBBParametricdivides each half axis by its length to recover the box rotation. A zero-length axis (flat box) produces NaN and skewed half axes produce a non-orthonormal matrix, so the ray is silently rejected or the caller crashes. Height sampling hits this on tilesets with such boxes.Now a single zero-length axis is rebuilt from the cross product of the other two, two or more return no hit, and the transformed ray direction is normalized so skewed boxes are still tested (with the hit distance scaled back to the original ray).
Issue number or link
I can create one if you want.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
New
IntersectionTests::rayOBB with malformed half axestest case: flat box hit on its face, flat box missed beside its face, box with no extent never hit, skewed box hit through its center. The test commit fails onmainand passes with the fix.