Repository navigation
docs: correct verified README and contribution instructions - #17
Open
SakarPaisen wants to merge 1 commit into
Open
SakarPaisen wants to merge 1 commit into
SakarPaisen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
What
Objective, verifiable documentation corrections in
README.mdandCONTRIBUTING.mdonly. No code, manifest, dependency, asset, or behaviour change.README.md
<p aligh="center">-><p align="center">in the screenshot block.5.Select->5. Select); without the space the line is not parsed as a list item.[LICENSE](LICENSE)->[LICENSE](LICENSE.md)(the repository containsLICENSE.md, no plainLICENSE).CONTRIBUTING.md
dist/firefox" -> "The generated Firefox extension is written to:dist/firefox".about:addons).[LICENSE](LICENSE)->[LICENSE](LICENSE.md).Why these specific changes (evidence)
build/build.jswrites the build todist/<browser>, sonpm run build:firefoxproducesdist/firefox. Both builds were run successfully and produceddist/chromeanddist/firefox.src/manifest/firefox.jsondeclaressidebar_action.default_panelandsrc/scripts/browser/firefox.jscallschrome.sidebarAction.open(), whilesrc/manifest/chrome.jsondeclaressidePanel/side_panel.default_pathandsrc/scripts/browser/chrome.jscallschrome.sidePanel.open(). So the Chrome text keeps "side panel" and the Firefox text says "sidebar".git ls-filesshowsLICENSE.mdand noLICENSE, so the previous license links 404'd.Validation
git diff --checknpm cinpm run format:checknpm testnpm run build:chromedist/chromenpm run build:firefoxdist/firefoxMarkdown is excluded from Prettier via
.prettierignore, so these doc edits cannot affectformat:check. A baseline run with the edits stashed produced identical results, so no failure was introduced and there is no known baseline failure.This change and PR description were prepared with AI assistance.