Skip to content

feat: New plugin made to support LuckPerms - #1258

Merged
0utplay merged 9 commits into
CloudNetService:nightlyfrom
RobotHanzo:luckperms-addon
May 19, 2024
Merged

feat: New plugin made to support LuckPerms#1258
0utplay merged 9 commits into
CloudNetService:nightlyfrom
RobotHanzo:luckperms-addon

Conversation

@RobotHanzo

@RobotHanzo RobotHanzo commented Jun 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

In PR #1253 CloudPerms was removed, making LuckPerms one of the best alternatives
But it lacks the feature of service / task exclusive permission
Therefor an optional plugin was made for those who want to use LuckPerms and use task exclusive permissions

Modification

Added a new plugin named CloudNet-LuckPerms-Addon to add some LuckPerms context (explained below)

Result

image
Four types of context were added: task, service, environment and node
Server admins may then setup context in their permissions if needed, to make a permission service / task exclusive
(Note: I only made the plugins for platforms which both CloudNet and LuckPerms support, and this has been tested on Paper &
Velocity)

Other context

N/A

0utplay
0utplay requested changes Jun 17, 2023
View reviewed changes
Comment thread ...erms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/CloudNetContextCalculator.java Outdated
Comment thread ...erms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/CloudNetContextCalculator.java Outdated
Comment thread ...erms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/BungeecordLuckPermsPlugin.java Outdated
@RobotHanzo
RobotHanzo requested a review from 0utplay June 17, 2023 16:40
@RobotHanzo

RobotHanzo commented Jun 17, 2023

Copy link
Copy Markdown
Contributor Author

Done.

@derklaro

derklaro commented Jun 17, 2023

Copy link
Copy Markdown
Member

Just want to throw this information here: we're planning on a seperate module to better support luckperms (for example auto downloading for the environments). I think this plugin would fit more into the module (or, we can leave it as a plugin but the LP code will be in a seperate repo anyway).

So this PR won't be merged here, but having that functionality seems like a great addition.

@RobotHanzo

RobotHanzo commented Jun 17, 2023

Copy link
Copy Markdown
Contributor Author

Just want to throw this information here: we're planning on a seperate module to better support luckperms (for example auto downloading for the environments). I think this plugin would fit more into the module (or, we can leave it as a plugin but the LP code will be in a seperate repo anyway).

So this PR won't be merged here, but having that functionality seems like a great addition.

Alright, I'd be glad to move this feature into the module when it's made

@derklaro derklaro added s: blocked Please do not merge, the pull request is not ready yet / waiting for something which is required v: 4.X This pull should be included in the 4.0 release t: improvement The pull request improves existing code in: module An issue/pull request releated to one of the internal modules labels Jun 19, 2023
@0utplay

0utplay commented May 18, 2024

Copy link
Copy Markdown
Member

Hi @RobotHanzo,
it took longer than we expected. But currently I am working the last preparations to remove cloudperms. The idea to create a new luckperms module is on ice (at least for now). So I would like to include the plugin you developed.

Can you maybe update this pr to RC10 and the latest minecraft version (1.20.4 is enough for now). If you don't have the time to do that, just leave a message and I will try to update the pr.

@RobotHanzo
Merge remote-tracking branch 'refs/remotes/upstream/nightly' into luc…
2266feb 
…kperms-addon

# Conflicts:
#	gradle/libs.versions.toml
@RobotHanzo

RobotHanzo commented May 18, 2024

Copy link
Copy Markdown
Contributor Author

Hi @RobotHanzo, it took longer than we expected. But currently I am working the last preparations to remove cloudperms. The idea to create a new luckperms module is on ice (at least for now). So I would like to include the plugin you developed.

Can you maybe update this pr to RC10 and the latest minecraft version (1.20.4 is enough for now). If you don't have the time to do that, just leave a message and I will try to update the pr.

Done

@0utplay

0utplay commented May 18, 2024

Copy link
Copy Markdown
Member

Please exec gradlew spotlessApply once

0utplay
0utplay reviewed May 18, 2024
View reviewed changes
Comment thread build-extensions/src/main/kotlin/Files.kt Outdated
Comment thread plugins/build.gradle.kts
Comment thread ...uckperms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/BukkitLuckPermsPlugin.java Outdated
Comment thread ...uckperms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/FabricLuckPermsPlugin.java Outdated
Comment thread ...uckperms-addon/src/main/java/eu/cloudnetservice/plugins/luckperms/SpongeLuckPermsPlugin.java Outdated
@RobotHanzo
RobotHanzo requested a review from 0utplay May 19, 2024 03:02
0utplay
0utplay previously approved these changes May 19, 2024
View reviewed changes

@0utplay 0utplay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just have one question left. Is there a reason we don't support groups in the context? I thought luckperms would support multiple values for the same context key.

@RobotHanzo

RobotHanzo commented May 19, 2024

Copy link
Copy Markdown
Contributor Author

I just discovered that context suggestions are supported, so I added that (Which I believe adds our contexts to the web panel for easier access)

@RobotHanzo
RobotHanzo requested a review from 0utplay May 19, 2024 09:49
0utplay
0utplay requested changes May 19, 2024
View reviewed changes
Comment thread .../luckperms/src/main/java/eu/cloudnetservice/plugins/luckperms/CloudNetContextCalculator.java Outdated
Comment thread .../luckperms/src/main/java/eu/cloudnetservice/plugins/luckperms/CloudNetContextCalculator.java Outdated
Comment thread .../luckperms/src/main/java/eu/cloudnetservice/plugins/luckperms/CloudNetContextCalculator.java Outdated
@RobotHanzo @0utplay
Apply suggestions from code review
a4d53eb 
Co-authored-by: Aldin <aldin@sijamhodzic.de>
@RobotHanzo
RobotHanzo requested a review from 0utplay May 19, 2024 09:57
@0utplay

0utplay commented May 19, 2024

Copy link
Copy Markdown
Member

Thanks for the contribution!

@0utplay
0utplay merged commit 3fc4b2a into CloudNetService:nightly May 19, 2024
@RobotHanzo
RobotHanzo deleted the luckperms-addon branch May 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0utplay 0utplay 0utplay approved these changes

Assignees

No one assigned

Labels

in: module An issue/pull request releated to one of the internal modules s: blocked Please do not merge, the pull request is not ready yet / waiting for something which is required t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobotHanzo @derklaro @0utplay