[WIP] allow attribute based self-colocation of promotable roles - #4165
Open
wenningerk wants to merge 2 commits into
Open
[WIP] allow attribute based self-colocation of promotable roles#4165wenningerk wants to merge 2 commits into
wenningerk wants to merge 2 commits into
Conversation
wenningerk
force-pushed
the
self_colocate
branch
from
August 18, 2026 15:16
19894c5 to
50e7cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
something like
I marked the commit as a feature but actually we could call it a fix as well.
Tooling already allowed to configure this kind of constraints and people would as well do it intuitively.
Up to now this kind of constraints had been some kind of safe-noop.
If we allow more than one instance of a promotable-clone per node simple colocation of promoted-role (without attribute) might make sense as well. Have to check if that is working as well already.