Hangs on large files #21

Activity

1. Cobertos commented on Oct 17, 2021

   

   Cobertos

   on Oct 17, 2021

   Last edited by Cobertos

   OwnerAuthor

   More actions

   I believe this was when switching to tarsafe instead of tarfile as tarsafe does a iteration over names which was a previous source of slowness

   Ideally tarsafe would need to be more performant... but I don't think Python gives any better way to check the tar before iteration.
2. Cobertos commented on Oct 17, 2021

   

   Cobertos

   on Oct 17, 2021

   Last edited by Cobertos

   OwnerAuthor

   More actions

   I'm thinking:

   1. Add an --unsafe flag to use tarfile instead of tarsafe
   2. Add a print message right before extraction like Extraction checks the security of every .tar file entry. To speed up, add --unsafe if you trust your .unitypackage is not malicious
3. Cobertos commented on Oct 17, 2021

   

   Cobertos

   on Oct 17, 2021

   OwnerAuthor

   More actions

   @catfag any thoughts maybe?
4. CrackerHax commented on Dec 16, 2021

   

   CrackerHax

   on Dec 16, 2021

   More actions

   Yeah this tool is super slow
5. OneManMonkeySquad commented on Jan 15, 2022

   

   OneManMonkeySquad

   on Jan 15, 2022

   More actions

   Having some output, either progress or just "working on it..." would help a lot
6. kotori2 commented on Dec 15, 2022

   

   kotori2

   on Dec 15, 2022

   More actions

   For me it is 58 seconds for a 2.2MB file.