Glasgow | 26-ITP-May | Sandani Kannangara | sprint 1 | Data groups#1233
Open
SandzSoft wants to merge 9 commits into
Open
Glasgow | 26-ITP-May | Sandani Kannangara | sprint 1 | Data groups#1233SandzSoft wants to merge 9 commits into
SandzSoft wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
SandzSoft
changed the title
This comment has been minimized.
This comment has been minimized.
SandzSoft
changed the title
SandzSoft
added
📅 Sprint 1
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work - your solution is correct. I have one question for you to investigate.
| function dedupe(array) { | ||
| if (!Array.isArray(array)) return []; | ||
|
|
||
| return [...new Set(array)]; |
There was a problem hiding this comment.
This is a clever approach. Does this preserve the array order?
Author
There was a problem hiding this comment.
Yes, it does. Set preserves the insertion order of elements, so converting the array to a Set and then back to an array keeps the first occurrence of each element in its original order while removing duplicates.
Thank you for reviewing, Leon!
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This PR implements solutions for Sprint 1 data group exercises, including dedupe, findMax, and sum functions. It also includes Jest tests for each function, covering basic cases, duplicates handling, and edge cases such as empty arrays and non-numeric values.