-
-
Notifications
You must be signed in to change notification settings - Fork 304
London | 26-ITP-May | Martin Mwaka | Sprint 1 | Exercises #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Temceo
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
Temceo:coursework/sprint-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cf27b97
Update fix/median.js to make tests pass
Temceo fe3b212
Write tests for implement/dedupe.test.js
Temceo 8478b48
Complete implement/dedupe.js - all tests pass
Temceo c8c5599
Update numbers filter in fix/median.js
Temceo d73f09c
Write tests for implement/max.test.js
Temceo 752c530
Complete implement/max.js - all tests pass
Temceo 8dad701
Complete implement/sum.js - all tests pass
Temceo e91162d
Update implement/max.js
Temceo 40aa890
Refactored refactor/includes.js
Temceo be1cf59
Updated refactor/includes.js to use for of loop
Temceo e6bb904
Complete solution on stretch/aoc-2018-day1/solution.js
Temceo 43561d7
Refactor dedupe.js
Temceo b98a26c
Refactor median.js to remove inFinite
Temceo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| function dedupe() {} | ||
| function dedupe(array) { | ||
| // return empty array if empty input | ||
| if (array.length === 0) return []; | ||
| return Array.from(new Set(array)); | ||
| } | ||
|
|
||
| module.exports = dedupe; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| function findMax(elements) { | ||
| // filter to return only numbers or an empty array | ||
| const numbers = elements.filter((item) => Number.isFinite(item)); | ||
| // if numbers present in array return largest number or return -Infinity for empty array | ||
| return numbers.length ? Math.max(...numbers) : -Infinity; | ||
| } | ||
|
|
||
| module.exports = findMax; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| function sum(elements) { | ||
| // filter out the numbers and sum them up | ||
| return elements | ||
| .filter((item) => Number.isFinite(item)) | ||
| .reduce((acc, num) => acc + num, 0); | ||
| } | ||
|
|
||
| module.exports = sum; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| const fs = require("fs"); | ||
| const path = require("path"); | ||
| const data = fs.readFileSync(path.join(__dirname, "input.txt"), "utf-8"); | ||
| const total = data | ||
| .split("\n") | ||
| .map((line) => line.trim()) | ||
| .filter((line) => line !== "") | ||
| .map(Number); | ||
|
|
||
| const mapFrequency = (changes) => changes.reduce((acc, num) => acc + num, 0); | ||
| console.log(mapFrequency([+1, +1, +1])); // 3 | ||
| console.log(mapFrequency([+1, +1, -2])); // 0 | ||
| console.log(mapFrequency([-1, -2, -3])); // -6 | ||
| console.log(mapFrequency(total)); // 529; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of chaining higher order functions together