Repository navigation
release: cut 1.13.5 as the first release with one version - #268
Merged
Merged
Conversation
v1.13.4 cannot be re-dispatched. Its tag points at 0f94109, where MARKETING_VERSION is already 1.13.4 but the crates are still 1.13.3 -- the drift is baked into the tag, so rebuilding it reproduces the same qualification failure that left v1.12.0 through v1.13.2 with no assets. This is the first cut where the version came from `pnpm version:sync` rather than from hand-editing four files: one edit to MARKETING_VERSION, and the script derived CURRENT_PROJECT_VERSION (11305), the three crate versions, the sibling pins, and Cargo.lock. `pnpm version:check` now gates this in ci.yml and, for the first time, in native-production-qualification.yml before signing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #267, which made
MARKETING_VERSIONthe only version and gated it in both pipelines.Why a new cut instead of re-running v1.13.4. Tag
v1.13.4points at0f941090, whereMARKETING_VERSIONis 1.13.4 butcrates/codevetter-core/Cargo.tomlis still1.13.3. The drift is inside the tag, so re-dispatchingrelease.ymlagainst it rebuilds the same tree and failscore:qualify-cliexactly as before — the failure that left v1.12.0–v1.13.2 with zero assets. The tag has to move past the drift.How this bump was made. One edit to
MARKETING_VERSION, thenpnpm version:sync, which derivedCURRENT_PROJECT_VERSION(11305), the three crate versions, the sibling=<version>pins, andCargo.lock. No file in this diff was hand-edited except the first line.pnpm version:checkreports the tree consistent.On merge,
auto-release.ymlcutsv1.13.5and dispatchesrelease.yml, which now runsversion:checkbefore signing. Expected outcome: four assets on v1.13.5 and the draft published by the manifest gate from #259.Refs #253.