Skip to content

Fix Zitadel generated password complexity requirements #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afscrome merged 2 commits into from
Sep 14, 2026
Merged

Fix Zitadel generated password complexity requirements #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8de63
Fix Zitadel generated password complexity requirements
afscrome Sep 12, 2026
8e98fa3
Test Zitadel generated password complexity guarantees
afscrome Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Aspire.Hosting.Zitadel/ZitadelHostingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static IResourceBuilder<ZitadelResource> AddZitadel(
ArgumentNullException.ThrowIfNull(name);

var usernameParameter = username?.Resource ?? new ParameterResource($"{name}-username", _ => "admin", false);
var passwordParameter = password?.Resource ?? ParameterResourceBuilderExtensions.CreateDefaultPasswordParameter(builder, $"{name}-password", minSpecial: 1);
var passwordParameter = password?.Resource ?? ParameterResourceBuilderExtensions.CreateDefaultPasswordParameter(builder, $"{name}-password", minLower: 1, minUpper: 1, minNumeric: 1, minSpecial: 1);
var masterKeyParameter = masterKey?.Resource ?? ParameterResourceBuilderExtensions.CreateGeneratedParameter(builder, $"{name}-masterKey", true, new GenerateParameterDefault
{
MinLength = 32, // Zitadel requires 32, CreateDefaultPasswordParameter generates 22
Expand Down
22 changes: 22 additions & 0 deletions tests/CommunityToolkit.Aspire.Hosting.Zitadel.Tests/ZitadelHostingExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,28 @@ public async Task AddZitadel_Sets_Admin_Username_And_Password()
Assert.True(env.ContainsKey("ZITADEL_FIRSTINSTANCE_ORG_HUMAN_PASSWORD"));
}

[Fact]
public void AddZitadel_Default_Password_Meets_Complexity_Requirements()
{
// Publish mode exposes the generator without wrapping it in persisted user secrets.
var builder = DistributedApplication.CreateBuilder(["Publishing:Publisher=manifest"]);
var zitadel = builder.AddZitadel("zitadel");

// Check the guarantees so this test cannot pass by chance if a minimum is removed.
var generation = Assert.IsType<GenerateParameterDefault>(zitadel.Resource.AdminPasswordParameter.Default);
Assert.True(generation.MinLower >= 1);
Assert.True(generation.MinUpper >= 1);
Assert.True(generation.MinNumeric >= 1);
Assert.True(generation.MinSpecial >= 1);

var password = generation.GetDefaultValue();

Assert.Contains(password, char.IsLower);
Assert.Contains(password, char.IsUpper);
Assert.Contains(password, char.IsDigit);
Assert.Contains(password, c => !char.IsLetterOrDigit(c));
}

[Fact]
public void AddZitadel_Uses_Custom_Username_And_Password()
{
Expand Down
Loading