Skip to content

Fix flaky SqlDatabaseProjects test: give each project its own database #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afscrome merged 2 commits into from
Sep 22, 2026
Merged

Fix flaky SqlDatabaseProjects test: give each project its own database #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94610e0
Fix flaky SqlDatabaseProjects test by giving each project its own dat…
afscrome Sep 22, 2026
aa5cfd8
Remove unnecessary comment from example AppHost
afscrome Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...-database-projects/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

var server = builder.AddSqlServer("sql");

var database = server.AddDatabase("TargetDatabase");
var database = server.AddDatabase("Database1");

var otherDatabase = server.AddDatabase("OtherTargetDatabase");
var chinookDatabase = server.AddDatabase("Database2");

var otherDatabase = server.AddDatabase("Database3");

var sdkProject = builder.AddSqlProject<Projects.SdkProject>("sdk-project")
.WithReference(database);
Expand All @@ -14,7 +16,7 @@
.WaitForCompletion(sdkProject);

builder.AddSqlPackage<Packages.ErikEJ_Dacpac_Chinook>("chinook")
.WithReference(database);
.WithReference(chinookDatabase);

var connection = builder.AddConnectionString("Aspire");

Expand Down
6 changes: 3 additions & 3 deletions tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/AppHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ namespace CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests;
public class AppHostTests(AspireIntegrationTestFixture<Projects.CommunityToolkit_Aspire_Hosting_SqlDatabaseProjects_AppHost> fixture) : IClassFixture<AspireIntegrationTestFixture<Projects.CommunityToolkit_Aspire_Hosting_SqlDatabaseProjects_AppHost>>
{
[Theory]
[InlineData("sdk-project", "SdkProject", "TargetDatabase")]
[InlineData("other-sdk-project", "SdkProject", "OtherTargetDatabase")]
[InlineData("chinook", "InvoiceLine", "TargetDatabase")]
[InlineData("sdk-project", "SdkProject", "Database1")]
[InlineData("other-sdk-project", "SdkProject", "Database3")]
[InlineData("chinook", "InvoiceLine", "Database2")]
public async Task ProjectBasedResourceStartsAndRespondsOk(string resourceName, string tableName, string database)
{
await fixture.ResourceNotificationService.WaitForResourceAsync(resourceName, KnownResourceStates.TerminalStates).WaitAsync(TimeSpan.FromMinutes(5));
Expand Down
Loading