Skip to content

feat: add MailPit support #476 - #479

Merged
aaronpowell merged 1 commit into
CommunityToolkit:mainfrom
prom3theu5:feature/mailpit
Feb 19, 2025
Merged

aaronpowell merged 1 commit into
CommunityToolkit:mainfrom
prom3theu5:feature/mailpit

Conversation

@prom3theu5

@prom3theu5 prom3theu5 commented Feb 17, 2025 •

Copy link
Copy Markdown
Contributor

This pull request adds support for a MailPit integration, including unit tests.

Documentation has been created under the PR: dotnet/docs-aspire#2633

This fulfils the proposal outlined in #476

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@prom3theu5

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration looks all good. @prom3theu5 are you willing to be added as the CODEOWNER of the integration?

@prom3theu5

Copy link
Copy Markdown
Contributor Author

Hi @aaronpowell
Yeah sure thats fine

@aaronpowell

Copy link
Copy Markdown
Member

Invite sent

@aaronpowell
aaronpowell merged commit 537fc3d into CommunityToolkit:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants