Repository navigation
fix(actions): pin the remaining named-residual workflows off ubuntu-latest - #1886
seonghobae merged 2 commits into
Conversation
…atest docs/product-technical-gap-baseline.md's earlier starved-ubuntu-latest entry deliberately scoped its fix to opencode-review-dispatch.yml (the file with direct, confirmed live evidence at the time) and explicitly named 5 residual files to revisit "if queuing symptoms recur on them specifically": pr-review-autofix.yml, pr-review-fix-scheduler.yml, hourly-review-repair.yml, codeql-pr.yml, codeql-scan-dispatch.yml. They did recur (a severe, hours-long org-wide Actions stall today) and all 5 were confirmed still on ubuntu-latest, plus a 6th, python-security.yml, found independently while investigating the same symptom. Pinned all 6 files (10 job occurrences total) to ubuntu-24.04, matching the already-validated pattern used by every other central required workflow (security-scan.yml, sast-semgrep.yml, agent-review-runtime-quality-ci.yml, pr-review-merge-scheduler.yml, strix.yml, opencode-review.yml, noema-review.yml, opencode-review-dispatch.yml). Added tests/test_scheduler_and_codeql_dispatch_runner_image_contract.py covering all 6, following the same contract-test shape as the existing security/review/scheduler runner-image tests. Important finding recorded in the gap-baseline doc: this fix does NOT explain today's dominant congestion. A direct queue query showed the org's actual in-progress job count (5-6) is far below the documented 60-job ceiling, while 307 runs sat queued -- and the single largest contributors (Required PR Review Merge Scheduler, Security Scan, SAST Semgrep, Agent Review Runtime Quality CI) were already pinned to ubuntu-24.04 before this pass and equally stuck. GitHub's own status page showed no active incident. The 5-6-vs-60 in-progress gap remains unexplained; flagged for follow-up rather than claimed as resolved by this fix. Verified: full suite + coverage green (pre-existing 98.3% docstring gap in review_admission_controller.py/pr_review_merge_scheduler_core.py/ audit_codeql_default_setup_rollout.py is unrelated -- .github#1883, in review, fixes it separately; none of those files are touched here). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Stack verification found the new runner-image contract test failed Ruff I001 because the import block had an extra separator. Fixed in the parent writer at exact head |
Measures run counts, cancelled/superseded share, and run-level queue/ duration percentiles per (repo, workflow, trigger) group across all 79 non-archived org repos in the last 24h, per the ci-centralization task. The baseline's live signature (single-digit in_progress vs 200+ queued on fast-mlsirm/.github, and fast-mlsirm PR #1882-#1884 check suites stuck QUEUED while #1885-#1886 succeeded) reproduces the org-wide concurrent-job ceiling already documented in docs/doctoring/actions-plan-concurrency-ceiling-20260903.md, not a workflow-file duplication problem. ADR 0030 scopes what workflow centralization can and can't do given that constraint, and records that the one low-risk fix this task's Step 3 proposed (add missing concurrency: blocks to required workflows) was already done org-wide before this session started. No workflow behavior changes in this PR.
Summary
docs/product-technical-gap-baseline.md's earlier starved-ubuntu-latestentry deliberately scoped its fix toopencode-review-dispatch.yml(the file with direct, confirmed live evidence at the time) and explicitly named 5 residual files to revisit "if queuing symptoms recur on them specifically":pr-review-autofix.yml,pr-review-fix-scheduler.yml,hourly-review-repair.yml,codeql-pr.yml,codeql-scan-dispatch.yml. They did recur (a severe, hours-long org-wide Actions stall today) and all 5 were confirmed still onubuntu-latest, plus a 6th,python-security.yml, found independently while investigating the same symptom.Pinned all 6 files (10 job occurrences total) to
ubuntu-24.04, matching the already-validated pattern used by every other central required workflow (security-scan.yml,sast-semgrep.yml,agent-review-runtime-quality-ci.yml,pr-review-merge-scheduler.yml,strix.yml,opencode-review.yml,noema-review.yml,opencode-review-dispatch.yml). Addedtests/test_scheduler_and_codeql_dispatch_runner_image_contract.pycovering all 6, following the same contract-test shape as the existing security/review/scheduler runner-image tests.Important caveat, recorded in the gap-baseline doc
This fix does NOT explain today's dominant congestion. A direct queue query showed the org's actual in-progress job count (5-6) is far below the documented 60-job ceiling, while 307 runs sat queued — and the single largest contributors (
Required PR Review Merge Scheduler,Security Scan,SAST Semgrep,Agent Review Runtime Quality CI) were already pinned toubuntu-24.04before this pass and equally stuck. GitHub's own status page showed no active incident. The 5-6-vs-60 in-progress gap remains unexplained; flagged for follow-up rather than claimed as resolved by this fix.Verification
coverage run -m pytest tests: 2838 passed, 1 skipped, 21 subtests passed.review_admission_controller.py/pr_review_merge_scheduler_core.py/audit_codeql_default_setup_rollout.py) is unrelated —.github#1883, in review, fixes it separately; none of those files are touched here.interrogateon the new test file: 100%.🤖 Generated with Claude Code