Repository navigation
fix(ui): make lineage group order locale-independent - #903
seonghobae wants to merge 49 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Exercise the Storybook LineageDag in real Chromium at desktop, intermediate, and mobile widths. Verify named and truly ungrouped identities remain separate across remount, mobile overflow stays inside the scroll region, keyboard focus is visible, and edge evidence opens from the keyboard.
Merge protected main@3f61c824 into the Lineage DAG UI branch without rewriting its history. The intervening main delta only adds docs/index.md and does not overlap the UI/layout/browser-acceptance changes.
Adopt protected main #923's docs-only Tests workflow delta without changing Event Lineage presentation semantics.
Adopt #924's restored docs-contract test triggering while preserving deterministic Event Lineage presentation without force rewrite.
Pull request was converted to draft
Adopt the protected #931 Draft-admission workflow delta on the Event Lineage branch while preserving the branch's product/UI changes. The protected delta and PR delta touch disjoint files, so this merge commit keeps both histories without destructive rebase.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh protected-main review found the branch still diverged from main@83eba56149eb802cd63642c507c324c9976ec78e by the six protected commits that introduced #931's repository-local Draft admission contract. The PR's 17 product/UI changed files do not overlap the four protected workflow/contract files, so leaving it on b0e94aa… would make the branch carry a stale CI contract and stale base evidence. Repaired non-destructively at e325b3f63fdb9c34a7c62ae58045ec36e34b1879: exact protected blobs for Tests/PROV-O/Ontology and tests/test_tests_workflow_contract.py were adopted, then a two-parent merge commit preserved both histories. No force-push/rebase or product delta rewrite. Current-head hosted gates and browser/a11y evidence must be re-established; predecessor evidence does not transfer.
Buyer-visible scope
This Draft repairs deterministic and accessible Event Lineage presentation without changing lineage truth, persistence, provenance, inference semantics, or domain identity.
The candidate keeps locale-independent reconstruct-group ordering; literal
Ungroupedidentity distinct from truly ungrouped records; input-order-independent node/edge layout; deterministic parallel-edge selection; locale-safe accessible disambiguation; offset-aware UTC ordering; stable selection across unrelated rerenders; pointer/touch acquisition for thin SVG edges; deterministic evidence-table ordering by domain evidence rank; and fail-closed duplicate canonical node identity, visible self-loops, and visible same-group directed cycles.Material-UI acceptance remains exact-head scoped. Predecessor local/hosted Storybook or Chromium evidence is not transferred after head movement.
TDD lineage retained
cab4cd016759450ccc17c500c6e5a41ab5536da4→ GREEN3de188f91f36124c13e35eadd6b86afba38e608f67044bdff74b7a9d6e64b840a9fa4758dcd551d6→ GREENa51efc49969918da984926972c9a2ed0dbbdaa200c8d503ef0c897dd0f7a2295bd0578d296503ea8→ GREEN95b6943febb9683273a0387697dd78d7a663f7f619595f583b2dc0dc1fac04ac9b909bbcfedf629f→ GREEN28ca1e397096aff7afc0e977bbbfa02bee5c5b22749f301b463fa04e6381bd92541c59d5b6061aa3→ GREENfef6343811dd76abed6970c2b7854581476600061a63d2980ca9c8e1bc2698bf90181a07b29bd4eeThese guards are presentation fail-closed behavior only. They create no synthetic node identity, replacement relationship, or new lineage fact.
Protected-main convergence
Fresh review
5116222327found that the branch still diverged from protectedmain@83eba56149eb802cd63642c507c324c9976ec78eby six commits. The intervening protected delta is #931's repository-local Draft-admission repair and touches only.github/workflows/{tests,prov-o-contract,ontology-pages}.ymlplustests/test_tests_workflow_contract.py; PR #903's 17 product/UI changed files are disjoint.The branch was repaired non-destructively at
e325b3f63fdb9c34a7c62ae58045ec36e34b1879: exact protected blobs for those four files were adopted and a two-parent commit preserved both histories. No force-push, destructive rebase, gate weakening, or product-delta rewrite was used.Exact live boundary
main@83eba56149eb802cd63642c507c324c9976ec78ee325b3f63fdb9c34a7c62ae58045ec36e34b1879b0e94aa…base evidence is superseded33902540271: completedskippedunder the protected Draft-admission contract33902540239, Security33902540308, SAST33902540204: queued at this snapshotKeep Draft. Re-establish current-head Storybook/Chromium desktop/mobile, responsive overflow, pointer/touch, keyboard/focus and accessibility evidence when the review lane is admitted; predecessor browser/check/review results do not transfer.
Documentation evidence boundary
docs/product-technical-gap-baseline.mdcontains dated historical overlays. Its olderb0e94aa…#903 snapshot is retained as historical evidence, not treated as the current live authority; this PR body and GitHub exact refs are the current delivery boundary until a non-destructive baseline overlay can supersede it without rewriting historical evidence.