Repository navigation
quality: agent-authored gap-004 heads land unformatted Rust and block the required lint check #513
Description
Finding
The required check Format, lint, test, rustdoc, and dependency policy fails on many currently open gap-004 Drafts for one recurring cause: cargo fmt --all --check reports diffs in the very files the head just added. cargo clippy --workspace --all-targets -- -D warnings is clean on the same heads, so formatting alone is the blocker.
Measured locally (toolchain 1.98.0, cargo fmt --all --check, counting Diff in lines) on exact remote heads:
| PR | head | fmt diffs | files |
|---|---|---|---|
| #419 | 8c4a7bac |
1 | crates/analysis_engine/tests/prompt_source_execution_contract.rs |
| #418 | a3cf12b3 |
5 | crates/analysis_engine/tests/style_source_execution_contract.rs |
| #421 | 067d308f |
3 | crates/analysis_engine/tests/modality_source_execution_contract.rs |
| #426 | 1e6b3859 |
7 | crates/analysis_engine/src/citation_edge_artifact.rs, crates/analysis_engine/tests/citation_edge_execution_contract.rs |
Each of these heads descends from a verified restack of main@a243f18d on which cargo fmt --all --check was clean, so the violations come from the commits pushed after the restack, not from the merge.
Why one issue rather than a comment per PR
Same cause, same remedy, several active writers. Per the repository's warning policy this is tracked once; individual PRs are not spammed with duplicates.
Remedy
cargo fmt --all before pushing; the writers own their heads and the change is formatting-only with no semantic effect. To stop the recurrence, the pre-push path used by the agent loop should run cargo fmt --all --check (or cargo fmt --all) so an unformatted head never reaches a required check.
Boundary
Do not repair by relaxing cargo fmt --all --check, excluding files, or adding #[rustfmt::skip]. The gate is correct; the heads are unformatted.
Tracking
- Owner: the writer of each affected head for the immediate fix; the agent-loop owner for the pre-push guard.
- Internal action deadline: 2026-09-21 (blocks a required check on every affected Draft).
- Next review: 2026-09-17.
Activity