Repository navigation
feat(auth): define generation-fenced identity key snapshot - #375
seonghobae wants to merge 6 commits into
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent review Review exact head Review read-only; preserve independent reviewer identity. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
Rate Limit Exceeded
|
|
Queued @opencode-agent ; Already queued @cwl-noema-review on this exact request for PR #375 at head |
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
5 similar comments
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
|
Already queued @cwl-noema-review and @opencode-agent on this exact request for PR #375 at head |
|
Closing as superseded by consolidated current-main Draft #487. #487 preserves this PR's exact key-snapshot production/test blobs and validates profile/generation/current-key authority inside the integrated federated verification chain. The consolidated head must earn its own exact-head gates and approval. |
Objective
Advance issue #314 with a provider-neutral identity-key snapshot. A verifier can bind a server-owned verifier profile to one immutable key-set generation and bounded cache lifetime so unknown keys, stale generations, pre-fetch use, or expired snapshots fail closed before key material is treated as current authority.
Exact current-head evidence
961f44a19c4ced87f8062b3ab9842a9a08d05235;5f7099cad795a74e102dcb9366b5968b875a84bd;39ad0fc5def7b9e1b48be9c797d4b34f71bd5eba;IdentityKeySnapshot.javaand its focused regression only;Key-authority contract
The immutable snapshot defensively copies exact trusted key identifiers, requires a positive generation fence, models
fetchedAtas inclusive andexpiresAtas exclusive, rejects malformed authority inputs, and authorizes a key only when the caller's expected generation matches and the snapshot is current.Scope boundary
Value type only. This does not parse JWTs, verify signatures, fetch discovery/JWK documents, store JWK bodies, choose algorithms, map issuer/audience/roles, modify controllers, or replace signed-HMAC authentication. Issue #314 remains open for those integrated guarantees.
Merge gate
Keep this exact head unchanged. Auto-merge may act only after every live required check remains terminal-success, zero valid unresolved findings remain, and a qualifying independent non-author approval is attached to this exact head. If live protection requires an updated base, rebuild or update against protected
mainand regenerate all base-sensitive evidence. No predecessor evidence transfers.